Cleaner rsync still submits messages to server

Open
#580 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
40/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Trace the cleaner rsync path triggered by “Visit complete” and follow the logic that decides whether to notify listeners. Reproduce or inspect the cleanup flow, then verify that a killed rsync instance no longer sends file-count messages to the server.

Written by the indexing model from the issue text.

Description

bug client

The cleaner rsync that removes files when "Visit complete" is triggered cleans up files properly, but still sends messages to the server to increment the file count for an rsync instance that has been killed by that point. The logic that sets whether to notify listeners is broken somewhere, and thus needs investigating.

Dominant language
Python
Stars
2
Forks
1
Avg merge
1d 12h
Merged PRs (30d)
22

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DiamondLightSource/python-murfey

All issues in DiamondLightSource/python-murfey

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.