Finalising all rsyncers through the instrument server seems to cause connection issues with the database
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start at multigrid_control.py around line 169 and trace how rsyncer finalisations run outside threads into validate_instrument_server_session_token. Use the reported SQLAlchemy OperationalError as the failure signal; done means finalising all rsyncers no longer causes the database connection to close unexpectedly.
Written by the indexing model from the issue text.
Description
The first error log:
`sqlalchemy.exc.OperationalError: (psycopg2.OperationalError) server closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
[SQL: SELECT session.id, session.name, session.visit, session.started, session.current_gain_ref, session.instrument_name
FROM session
WHERE session.id = %(id_1)s]
[parameters: {'id_1': 22}]
(Background on this error at: https://sqlalche.me/e/20/e3q8)`
occurring in validate_instrument_server_session_token in auth.
The rsyncer finalisatons happen outside of threads (https://github.com/DiamondLightSource/python-murfey/blob/7e412424845eda96abed07165b781f433cc6ad56/src/murfey/client/multigrid_control.py#L169) which may cause issues
- Dominant language
- Python
- Stars
- 2
- Forks
- 1
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 22
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiamondLightSource/python-murfey
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
-
Difficulty 5/5 Over a week Newbie friendliness 15/100
All issues in DiamondLightSource/python-murfey
Similar issues
-
documentation help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
simonw/sqlite-utils#872 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100