Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Revaluate if use of -1 value is intuitive

Open
  • Is something wrong?
#72 0 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@Oli-Jones475 is already working on this.

Since Oct 6, 2025.

Assessment

This issue has not been assessed yet.

Description

Found another case where a value of -1 is being used where it's possible that something like an optional type would be more intuitive: https://github.com/DiamondLightSource/TomoHub/blob/b98db1054e7e6a143b0e6a416bf4646f1192015e/frontend/src/components/crop/SelectionOperations.ts#L55-L57

It'd be worth quickly reviewing this and the context in which it's being used to see if a value of -1 is the best way to express the desired behaviour.

Dominant language
TypeScript
Stars
2
Forks
1
Avg merge
15h 17m
Merged PRs (30d)
50

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DiamondLightSource/ImagingHub

All issues in DiamondLightSource/ImagingHub

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.