Failure to generate config file results in "success" notification

Open Beginner friendly
#89 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
frontend

Research direction

Start in the Methods page component YamlGenerator.tsx and reproduce the issue by refreshing to a blank page, then clicking Get Config. Inspect the snackbar error-handling logic and verify that the success notification appears only when configuration generation succeeds; confirm that failures do not report success.

Written by the indexing model from the issue text.

Description

bug good first issue

In the "Methods" page, even when the config file fails to be generated (for example, when clicking the "Get Config" button after a refresh of the page, so the page is completely blank), a notification pops up saying "Configuration file generated successfully", which is misleading.

See the screenshot below for an example:

Image

The error likely resides in the component in YamlGenerator.tsx, somewhere in the error-handling logic for when the snackbar should or shouldn't be displayed.

Dominant language
TypeScript
Stars
2
Forks
1
Avg merge
7h 4m
Merged PRs (30d)
24

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from DiamondLightSource/ImagingHub

All issues in DiamondLightSource/ImagingHub

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.