Redundant tag-push check in push step of container image build workflow file
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 45/100
Research direction
Inspect .github/workflows/_tomohub.yml, especially the tag trigger near lines 3-6 and the final container-image push step near line 59. Confirm the trigger already limits runs to tag pushes, then remove the redundant condition and verify the workflow still pushes the image for tag-triggered runs.
Written by the indexing model from the issue text.
Description
The workflow is configured to trigger on a push of a git tag: https://github.com/DiamondLightSource/TomoHub/blob/c931d678180cb6c53a55f214e9672e38b6300775/.github/workflows/_tomohub.yml#L3-L6
and yet the final step is checking if the event was a "push" and if there's a tag before the step runs (which is pushing the built container image): https://github.com/DiamondLightSource/TomoHub/blob/c931d678180cb6c53a55f214e9672e38b6300775/.github/workflows/_tomohub.yml#L59
The latter check is redundant due to the former already constraining the workflow to run only on a push of a tag.
- Dominant language
- TypeScript
- Stars
- 2
- Forks
- 1
- Avg merge
- 15h 17m
- Merged PRs (30d)
- 50
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiamondLightSource/ImagingHub
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
DiamondLightSource/ImagingHub#187 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
DiamondLightSource/ImagingHub#104 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
DiamondLightSource/ImagingHub#99 ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
DiamondLightSource/ImagingHub#89 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
DiamondLightSource/ImagingHub#44 ·
Maintainers usually reply within 1 day
All issues in DiamondLightSource/ImagingHub
Similar issues
-
area: desktop area: website priority: P2 type: feature
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
appandflow/stim#3411 · 1 comment ·
Maintainers usually reply within 1 day
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
rjsf-team/react-jsonschema-form#5485 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 65/100
lingdojo/kana-dojo#32090 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
friction
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
kentcdodds/kody#3265 ·
Maintainers usually reply within 1 day