Return error HTML page if visiting non-existent route
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- nginx
- Domain
- frontend
Research direction
Inspect frontend/nginx.conf at the linked lines and locate the built 50x.html page. Start by checking how non-existent routes are handled, then verify in a browser that such a route returns the error page instead of a blank response.
Written by the indexing model from the issue text.
Description
In the build there's a simple page called 50x.html that's intended for use as an error page to return to the user if they visit a non-existent route. We currently don't make use of this in the nginx config: https://github.com/DiamondLightSource/TomoHub/blob/8697a2af2fe374fa29c2ee1b28180be680aeeba4/frontend/nginx.conf#L1-L23
so at the moment, nothing is returned to the user's web browser (the page is blank). Returning this error page would be good to do.
- Dominant language
- TypeScript
- Stars
- 2
- Forks
- 1
- Avg merge
- 17h 16m
- Merged PRs (30d)
- 44
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiamondLightSource/ImagingHub
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
DiamondLightSource/ImagingHub#187 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
DiamondLightSource/ImagingHub#104 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
DiamondLightSource/ImagingHub#99 ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
DiamondLightSource/ImagingHub#89 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
DiamondLightSource/ImagingHub#44 ·
Maintainers usually reply within 1 day
All issues in DiamondLightSource/ImagingHub
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
stellar/stellar-dev-skill#151 ·
Maintainers usually reply within 1 day
-
area:arcade game ready-for-agent
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
fderuiter/deruiter.dev#2281 · 1 comment ·
Maintainers usually reply within 1 day
-
scope: data grid type: bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 2 days
-
fix(frontend): correct VITE_IS_DEVELPOMENT typo in shared/app.ts and align dev environment flagsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
vicharanashala/ajrasakha#1439 ·
Maintainers usually reply within 1 day
-
Add: TV5Monde AsieOpenapproved check:passed streams:add
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day