Revaluate use of `type="number"` in MUI `TextField` component
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 30/100
- Issue type
- Refactor
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
Start with the referenced frontend/src/components/Loader.tsx location around line 271 and read the linked MUI TextField guidance. Search the codebase for other type="number" uses, then determine whether they should be changed and what replacement behavior is required. The issue does not define a concrete completion condition, so confirm the intended scope before starting.
Written by the indexing model from the issue text.
Description
There are some uses of this in the codebase, such as the following: https://github.com/DiamondLightSource/TomoHub/blob/067cbda673c64316dfdd9d91201b29c8b367215f/frontend/src/components/Loader.tsx#L271
but the React MUI library docs at the time of writing state that use of type="number" is not advisable for "potential usability issues". See their docs page for more info.
Likely not an issue at the moment, but something worth bearing in mind.
- Dominant language
- TypeScript
- Stars
- 2
- Forks
- 1
- Avg merge
- 15h 17m
- Merged PRs (30d)
- 50
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from DiamondLightSource/ImagingHub
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
DiamondLightSource/ImagingHub#187 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
DiamondLightSource/ImagingHub#104 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
DiamondLightSource/ImagingHub#99 ·
Maintainers usually reply within 1 day
-
bug good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
DiamondLightSource/ImagingHub#89 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 85/100
DiamondLightSource/ImagingHub#44 ·
Maintainers usually reply within 1 day
All issues in DiamondLightSource/ImagingHub
Similar issues
-
submodule-pointer-regression
Difficulty 1/5 Under an hour Newbie friendliness 72/100
smith-horn/skillsmith#3061 ·
Maintainers usually reply within 1 day
-
area: ops type: test
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
accensa/x402-facilitator-stellar#559 ·
Maintainers usually reply within 1 day
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
cosimochellini/one-piece-zero-spoiler#551 ·
Maintainers usually reply within 1 day
-
getWatched() omits __proto__ directories when cwd is setPossibly taken @maxazure claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
-
area:web enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day