Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

unused_qualification lint warnings

Open
  • Is something wrong?
#1,071 1 comment 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@allan2 is already working on this.

Since Oct 25, 2024.

Assessment

This issue has not been assessed yet.

Description

When running Clippy, there are lots of warnings like

warning: unnecessary qualification
   --> crates\win-api-wrappers\src\thread.rs:175:54
    |
175 |             ThreadAttributeType::ParentProcess(_) => mem::size_of::<HANDLE>(),
    |                                                      ^^^^^^^^^^^^^^^^^^^^^^
    |
help: remove the unnecessary path segments
    |
175 -             ThreadAttributeType::ParentProcess(_) => mem::size_of::<HANDLE>(),
175 +             ThreadAttributeType::ParentProcess(_) => size_of::<HANDLE>(),

std::mem::size_of and mem::size_of both fail this lint.

I suggest removing the lint if the maintainers prefer to use mem::size_of, or to accept the lint suggestion, i.e., unqualified size_of.

I can make a PR for this pending guidance.

#1068 related

Dominant language
Rust
Stars
161
Forks
30
Avg merge
2d 21h
Merged PRs (30d)
38

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Devolutions/devolutions-gateway

All issues in Devolutions/devolutions-gateway

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.