picky-krb 0.12.5 fails to compile with picky-asn1-der < 0.5.7 or picky-asn1-x509 < 0.15.5
Maintainers usually reply within 3 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Newbie friendliness
- 80/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- build-system
Research direction
Start with picky-krb/Cargo.toml, where the issue identifies the dependency minimums that are too low. Raise them to the versions stated in the issue, then verify the manifest and run an appropriate build or test; done when consumers with the older locked versions can no longer select incompatible dependencies.
Written by the indexing model from the issue text.
Description
Summary
picky-krb 0.12.5 uses picky_asn1_der::Length (added in picky-asn1-der 0.5.7) and picky_asn1_x509::oids::iakerb5 (added in picky-asn1-x509 0.15.5), but its manifest still declares picky-asn1-der = "0.5" and picky-asn1-x509 = "0.15". A consumer whose lockfile already holds older patch versions gets picky-krb 0.12.5 without the versions it needs, and picky-krb itself fails to compile.
Inside this repository the dependencies are path dependencies, so CI always builds against the local sources and does not see it.
Reproduction
In a project whose Cargo.lock has picky-asn1-der 0.5.6 and picky-asn1-x509 0.15.4 (for example Devolutions/sspi-rs at b21f458):
cargo update -p picky-krb --precise 0.12.5
cargo build
error[E0432]: unresolved import `picky_asn1_der::Length`
error[E0432]: unresolved import `picky_asn1_x509::oids::iakerb5`
error[E0689]: can't call method `checked_add` on ambiguous numeric type `{integer}`
After cargo update -p picky-asn1-der --precise 0.5.7 and cargo update -p picky-asn1-x509 --precise 0.15.5, picky-krb compiles.
Suggested fix
Raise the declared minimums in picky-krb/Cargo.toml to picky-asn1-der = "0.5.7" and picky-asn1-x509 = "0.15.5" in the next release. A cargo +nightly update -Z direct-minimal-versions build in CI would catch this class of problem.
Related
The same release adds GssApiMessageError::InvalidMechanismOid, which the 0.12.5 changelog marks as breaking; Devolutions/sspi-rs#764 adapts to it.
- Dominant language
- Rust
- Stars
- 70
- Forks
- 43
- Avg merge
- 2d 12h
- Merged PRs (30d)
- 2
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Devolutions/picky-rs
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
Devolutions/picky-rs#264 · 8 comments ·
Maintainers usually reply within 3 days
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Devolutions/picky-rs#257 · 2 comments ·
Maintainers usually reply within 3 days
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Devolutions/picky-rs#249 · 2 comments ·
Maintainers usually reply within 3 days
-
enhancement help wanted
Difficulty 5/5 Over a week Newbie friendliness 20/100
Devolutions/picky-rs#248 · 4 comments ·
Maintainers usually reply within 3 days
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Devolutions/picky-rs#212 · 1 comment ·
Maintainers usually reply within 3 days
All issues in Devolutions/picky-rs
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
element-hq/lk-jwt-service#248 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
pact-foundation/pact-cli#154 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
antithesishq/bombadil#361 ·
Maintainers usually reply within 1 day
-
test(executor_l0): assert execute() TaskOutcome, not only bus events / 断言 execute() 返回的 TaskOutcomeOpentype:debt
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
skaiy/wild_agentos#425 ·
Maintainers usually reply within 1 day