third-party JSON dependency included in header
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- build-system
Research direction
Inspect the SDK's public headers and implementation files for the nlohmann/json include and the hardcoded dependency path. Move the dependency use into the .cpp implementation so clients are not required to pull in or resolve nlohmann/json through the header.
Written by the indexing model from the issue text.
Description
The third party dependency nlohmann/json is included in the header, which means clients of this SDK will also be pulling it in. this can conflict with a different but existing version of that library, and also means if a client is using a different JSON library, it now depends on multiple JSON libs. the path specified for that JSON dependency is also hardcoded
it would be great to move this dependency to the .cpp so clients don't need to worry about it
- Dominant language
- C++
- Stars
- 34
- Forks
- 25
- Avg merge
- 1h 7m
- Merged PRs (30d)
- 3
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Countly/countly-sdk-cpp
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
Countly/countly-sdk-cpp#103 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Countly/countly-sdk-cpp#100 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Countly/countly-sdk-cpp#36 · 4 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
Countly/countly-sdk-cpp#35 · 3 comments ·
-
No namespaceOpen
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
Countly/countly-sdk-cpp#33 · 1 reaction ·
All issues in Countly/countly-sdk-cpp
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
NVIDIA-Omniverse/usd-brep#23 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
qbittorrent/qBittorrent#25121 ·
Maintainers usually reply within 2 days
-
SVT-AV1: Unnecessary size paddingPossibly taken @pszemus claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
strukturag/libheif#1945 ·
Maintainers usually reply within 1 day
-
v9.6.0: CMake incorrectly enforces presence of libevdevPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
mltframework/shotcut#1943 ·
Maintainers usually reply within 1 day