No namespace
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- cpp
- Domain
- developer-experience
Research direction
Start by inspecting the countly.hpp header and locate the using json declaration and other top-level contents. The change is complete when including the header no longer pollutes the global namespace and existing SDK clients can still compile without the namespace workaround.
Written by the indexing model from the issue text.
Description
Without a namespace, the contents of the header polute the global namespace. in particular, the using json is quite unfortunate
clients of this SDK need to wrap the #include <countly.hpp> in a namespace as a work-around
- Dominant language
- C++
- Stars
- 34
- Forks
- 25
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Countly/countly-sdk-cpp
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
Countly/countly-sdk-cpp#103 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Countly/countly-sdk-cpp#100 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Countly/countly-sdk-cpp#36 · 4 comments ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
Countly/countly-sdk-cpp#35 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Countly/countly-sdk-cpp#34 ·
All issues in Countly/countly-sdk-cpp
Similar issues
-
P2: A timed rotation maneuver does nothing on a ship that had an earlier timed lateral maneuverOpen
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
scp-fs2open/fs2open.github.com#7914 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
eclipse-score/inc_someip_gateway#356 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
HarperFast/rocksdb-js#945 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day