Optional tools are fetched from master, and cmake/ikos.cmake is included nowhere
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 69/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Domain
- build-system, devops
Research direction
Read the three named CMake modules, scripts/release/check-pinned-dependencies.sh, and the relevant section of CMakeLists.txt. Pin flawfinder and TscanCode, update the script exclusions, and remove the unused ikos module and commented include. Run check-pinned-dependencies.sh, ctest, and configure and build with both options enabled to verify the acceptance criteria.
Written by the indexing model from the issue text.
Description
Three build modules fetch GIT_TAG master:
cmake/flawfinder.cmake:7(-DENABLE_FLAWFINDER=ON);cmake/tscancode.cmake:7(-DENABLE_TSCANCODE=ON);cmake/ikos.cmake:55, which nothing includes: itsincludeis commented out inCMakeLists.txt:144, and ikos is found throughPATH.
scripts/release/check-pinned-dependencies.sh skips these three files because no release ships those tools. As a result, two builds of the same commit with the same option can get different versions of flawfinder or TscanCode, and cmake/ikos.cmake is dead code.
To do
- Pin flawfinder and TscanCode to a tag or a commit, like the other dependencies.
- Remove them from the exclusion list of
check-pinned-dependencies.sh. - Delete
cmake/ikos.cmakeand the commentedinclude.
Acceptance
check-pinned-dependencies.shchecks every file incmake/, andctestpasses.- A build with
-DENABLE_FLAWFINDER=ON -DENABLE_TSCANCODE=ONstill configures and builds.
From the technical debt register (docs/quality/technical-debt.md, D7).
- Dominant language
- C++
- Stars
- 5
- Forks
- 4
- Avg merge
- 1h 4m
- Merged PRs (30d)
- 71
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CoreTrace/coretrace
-
documentation severity/minor
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
chore good first issue severity/minor
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
build severity/minor
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
build good first issue severity/minor
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
good first issue test
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
All issues in CoreTrace/coretrace
Similar issues
-
bug format I/O medium priority rt_lib
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
refactor
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
compiler-explorer/compiler-explorer#9272 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Difficulty 1/5 Under an hour Newbie friendliness 76/100
Maintainers usually reply within 1 day