Remove USE_EXTERNAL_CLI11: it downloads CLI11 2.3.2 while the vendored header is 2.5.0
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cmake, cpp
- Domain
- build-system
Research direction
Read the USE_EXTERNAL_CLI11 option and conditional block in CMakeLists.txt, then inspect cmake/CLI11.cmake and references found with the two git grep commands in the issue. Remove the option and module, then run the listed build, ctest, and format check commands. Done means the vendored CLI11 header is used and no references to the option or module remain.
Written by the indexing model from the issue text.
Description
ctrace parses its command line with the CLI11 header vendored in external/CLI11.hpp, version 2.5.0. With -DUSE_EXTERNAL_CLI11=ON (CMakeLists.txt:115-120), CMake downloads CLI11 v2.3.2 instead (cmake/CLI11.cmake): an older version that CI never builds, while the release license check reads the vendored header (CMakeLists.txt:209-214). The option gives two possible versions of the same dependency, and nothing needs it.
To do: remove the option and keep the vendored header.
How:
- delete
cmake/CLI11.cmake; - delete the
USE_EXTERNAL_CLI11option and itsifblock inCMakeLists.txt(lines 115 to 120); - run
git grep -n USE_EXTERNAL_CLI11andgit grep -n CLI11.cmaketo check that nothing else refers to them.
The wiki's build page also lists the option; a maintainer will update it.
Check:
cmake --build build --parallel 4
ctest --test-dir build --output-on-failure
./scripts/format-check.sh
Acceptance
cmake/CLI11.cmakeis gone, andgit grep USE_EXTERNAL_CLI11finds nothing.- The README build configures and builds, and
ctestpasses.
From the technical debt register (docs/quality/technical-debt.md, D8).
- Dominant language
- C++
- Stars
- 5
- Forks
- 4
- Avg merge
- 1h 9m
- Merged PRs (30d)
- 81
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CoreTrace/coretrace
-
chore good first issue severity/minor
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
build severity/minor
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
CoreTrace/coretrace#176 · 1 comment ·
Maintainers usually reply within 1 day
-
test: add unit tests for ctrace::RunDirectoryPossibly taken @tecnolgd claimed this 2 days ago. Opengood first issue test
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
CoreTrace/coretrace#164 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Release a macOS disk image (.dmg) for Apple siliconPossibly taken @SizzleUnrlsd claimed this today. Openbuild enhancement
CoreTrace/coretrace#198 · 1 assignee ·
Maintainers usually reply within 1 day
-
Builds without a build type are unoptimized: the README's commands and CI's main jobPossibly taken @SizzleUnrlsd claimed this 1 day ago. Openbuild severity/minor
CoreTrace/coretrace#192 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in CoreTrace/coretrace
Similar issues
-
bot-triaged module: correctness (silent) module: mps module: NaNs and Infs triage review
Difficulty 2/5 Half a day Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
SCIInstitute/SCIRun#2842 ·
Maintainers usually reply within 3 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
agent:Windows bug code-review LOW testing
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
Maintainers usually reply within 1 day