Remove the deprecated spellings, and --output-file, which no tool uses
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- cpp
- Domain
- cli, documentation, testing
Research direction
Start with the deprecated option and key handling in src/App/Config.cpp, src/App/ToolConfig.cpp, and include/ctrace_defs/types.hpp; review the tests and docs/configuration.md section named in the issue. Update the warning for --output-file and output_file, then remove the listed compatibility paths, their tests, and the Legacy Compatibility section. Update CHANGELOG.md for the removal release and run ctest; removed keys and options should be rejected.
Written by the indexing model from the issue text.
Description
ctrace still accepts spellings that were replaced, each with its own code path, tests and documentation:
| Spelling | Replaced by | Where |
|---|---|---|
--async, runtime.async |
--jobs, runtime.jobs (#158) |
src/App/Config.cpp:151, src/App/ToolConfig.cpp:729 |
--ipc=socket |
--ipc=standardIO (#83) |
include/ctrace_defs/types.hpp:26-41 |
Root invoke and input, stack_analyzer legacy keys, stack_analyzer.include_dirs and defines, tools.ctrace_stack_analyzer, tools.stack_analyzer |
The canonical sections (#87) | src/App/ToolConfig.cpp (applyLegacyRootInvokeAndInput, deprecated); docs/configuration.md, "Legacy Compatibility" |
--output-file (config output.output_file, API output_file) is in a worse state: its help text says "Legacy output path; no current tool writes to it" (src/App/Config.cpp:72). It is accepted, without any warning, and does nothing.
To do
- Make
--output-fileandoutput_filewarn like the other deprecated spellings. - In
CHANGELOG.md, announce the release that removes them all. - In that release, remove them, with their tests and the "Legacy Compatibility" section of
docs/configuration.md.
Acceptance
- After the removal, a removed key is rejected with the unknown-key diagnostic that names the allowed keys, and a removed option is rejected by the CLI.
ctestpasses.
From the technical debt register (docs/quality/technical-debt.md, D6).
- Dominant language
- C++
- Stars
- 5
- Forks
- 4
- Avg merge
- 1h 4m
- Merged PRs (30d)
- 71
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CoreTrace/coretrace
-
documentation severity/minor
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
-
chore good first issue severity/minor
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
build severity/minor
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Maintainers usually reply within 1 day
-
build good first issue severity/minor
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
good first issue test
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 1 day
All issues in CoreTrace/coretrace
Similar issues
-
1 type: problem 2 scope: firmware 3 good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
SpaceTeam/STS1_COBC_SW#511 ·
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
imaaiagent/fumi#3 ·
-
A bare port in --modelserver does not reach the model serverPossibly taken A pull request linked to this issue is open or already merged. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
rocketride-org/rocketride-server#2618 · 1 comment ·
Maintainers usually reply within 1 day
-
bug format I/O medium priority rt_lib
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
refactor
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day