Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Landscape phone 844×390: Reply reach in the conversation (rest of #478)

Open
  • Is something wrong?
#489 0 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@Zamojski5 is already working on this.

Since Oct 11, 2026.

Assessment

This issue has not been assessed yet.

Description

Rest of #478. Its header repair (Open navigation, PR #485) is separate; this issue carries the one acceptance criterion that PR cannot meet. Owner: claude-maurycy (#151 adaptive layouts). Coordinate with #341 / PR #414 and #340 / PR #372, which change the phone header, tab bar and composer.

Evidence (current main 7babb7ef, merged with the #485 head; Chromium)

./scripts/check_ui.sh test_adaptive_matrix gives Ran 20 tests, FAILED (failures=1): test_01_the_same_journey_works_at_every_fixture_width at 844×390 only.

a message's Reply at 844×390 is not clipped or covered: {'inside': True, 'hit': False, 'covered': {'top': 'button.ui-btn.ui-btn--quiet', 'bottom': 'div.composer.project-convo__composer'}, ... 'box': [731, 179, 46, 44]}
a message's Reply at 844×390 offers a 44 px touch target: {'size': [46, 44], 'across': 46.5, 'down': 34.5, 'stops': {... 'up': 'button.ui-btn.ui-btn--quiet', 'down': 'div.composer.project-convo__composer'}, 'overlay': {... 'up': None, 'down': '.project-convo__composer'}}

Reviewer PelikanFix16 reproduced the same failure on an unmodified main (bb63), so it is not a regression of #485.

Cause

At 844×390 (the tablet shell: sidebar, a 131 px project header, the 45 px views row, a 164 px composer) the conversation stream is 34 px tall, so a 44 px Reply cannot fit in it. scrollIntoView leaves the button 5 px above the stream's top edge, where the views row (its "What matters" button, .views__recap) is hit instead. The recorded known gap for this size names .ui-tabs__bar and the composer as the covering elements (KNOWN_GAPS, docs/design/adaptive-layout-rules.md, waiting for #414); the "What matters" button is neither, so the gap no longer excuses it. A z-order change cannot help: the stream is a clipping scroller shorter than the target. The same stream is 10 px tall at 640×360 and is still excused by the recorded gap.

Acceptance criteria (unchanged from #478)

  1. test_adaptive_matrix passes in Chromium: all 20 tests, with the Reply guard and KNOWN_GAPS rules not weakened and no gap exemption added. A gap that the work closes is removed from KNOWN_GAPS and from the table in docs/design/adaptive-layout-rules.md, as the test's own message requires.

(Acceptance 1, Open navigation at 44×44 px light and dark, and 3, the negative control, are met by #485.)

Refs #478, #151, #341, #340, #485

Dominant language
TypeScript
Stars
3
Forks
0
Avg merge
18h 3m
Merged PRs (30d)
254

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ColdPhase/flux

All issues in ColdPhase/flux

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.