check_ui.sh: refuse an unknown test module before building anything
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- bash, docker, python
- Domain
- developer-experience, testing
Research direction
Start in scripts/check_ui.sh: the argument comment is at lines 6-7, and the existing early FLUX_UI_BROWSER check at lines 11-17 shows the pattern to follow before any docker command. Arguments reach python3 -m unittest at lines 64-68, which run in app/tests/ui/. Done when an unknown module such as test_doc exits with status 2 and the stderr message before Docker starts, test_docs and Module.Class.test still work, and the header comment mentions the early refusal.
Written by the indexing model from the issue text.
Description
./scripts/check_ui.sh test_doc (a typo for test_docs) builds the images and starts the Compose stack before unittest fails with a missing-module error, several minutes later. The script already rejects a wrong FLUX_UI_BROWSER before Docker starts; module names should get the same early check.
Where to look
scripts/check_ui.sh(lines 6–7): the comment that describes the arguments (test_docs, orModule.Class.test).scripts/check_ui.sh(lines 11–17): the existing earlyFLUX_UI_BROWSERcheck, which runs before Docker or temporary secrets.scripts/check_ui.sh(lines 64–68): where the arguments reachpython3 -m unittestin theui-testcontainer (working directory/work/tests/ui, which isapp/tests/ui/in the repository).
Acceptance criteria
- For each argument, the module part (the text before the first
.) must be a fileapp/tests/ui/<module>.py; otherwise the script printsunknown UI test module: <module>to stderr and exits with status 2 before anydockercommand runs. -
Module.Class.testarguments and running with no arguments keep working as today. - The header comment says that unknown modules are refused early.
How to check
./scripts/check_ui.sh test_doc exits at once with the message and no Docker activity (docker ps shows no new flux-ui-* project). ./scripts/check_ui.sh test_docs still runs that module. Then the repository checks: python3 scripts/check_agent_setup.py, python3 -m unittest discover -s tests -p 'test_*.py', git diff --check.
New to Flux? Start with CONTRIBUTING. Comment here to say you are taking it.
- Dominant language
- TypeScript
- Stars
- 3
- Forks
- 0
- Avg merge
- 14h 40m
- Merged PRs (30d)
- 242
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ColdPhase/flux
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
F-027 A10 — Connect AI order and labels in Settings (rest of #410)Possibly taken @Zamojski5 claimed this today. Open
ColdPhase/flux#493 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
-
WebKit: scenarios test_1 intermittently fails adding the next person (status keeps the previous name); test_2 skippedPossibly taken @Zamojski5 claimed this today. Open
ColdPhase/flux#491 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
cline/mcp-marketplace#2932 ·
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 82/100
lingdojo/kana-dojo#32188 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Portkey-AI/gateway#1844 ·
Maintainers usually reply within 1 day
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 61/100
rjsf-team/react-jsonschema-form#5495 ·
Maintainers usually reply within 2 days