check_application.sh: run only the API test files you name
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 75/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- docker-compose, shell, typescript
- Domain
- developer-experience, testing
Research direction
Start with scripts/check_application.sh, lines 55-70, where the build, stack start and $compose run --rm test step run every API test file. The test service's default command is in docker/compose.source.yaml around line 320. Copy the named-module handling from scripts/check_ui.sh (lines 6-7 and 64-68). Done means: passing test paths runs only those files and skips the e2e and restart checks, a missing path exits 2 before Docker starts, and no-argument behaviour is unchanged.
Written by the indexing model from the issue text.
Description
To check one change to an API test that needs the database or the API, a contributor must run the whole Docker suite: every API test file, then every browser and restart check. Only the *-core.test.ts files can run on their own, in the test image. ./scripts/check_ui.sh already accepts the modules to run (#204); ./scripts/check_application.sh should accept API test files the same way.
Where to look
scripts/check_application.sh(lines 55–70): build, stack start, VAPID keys, then$compose run --rm testruns every API test file; the e2e and restart checks follow.docker/compose.source.yaml(line 320): thetestservice's default command,tsx --test --test-concurrency=1 tests/app/*.test.ts.scripts/check_ui.sh(lines 6–7 and 64–68): how named modules are handled there.docs/development/architecture.md(§ Tests) anddocs/CONTRIBUTING.md(§ Verify your change).
Acceptance criteria
-
./scripts/check_application.sh tests/app/search.test.ts(one or more paths underapp/tests/app/, as seen fromapp/) runs only those files in thetestservice, with the same stack and environment, and skips the e2e and restart checks; it says so in its output. - A path that does not exist is refused before Docker starts, with exit status 2.
- Without arguments the script behaves exactly as today.
- CONTRIBUTING § Verify your change shows the one-file command, replacing its interim note that only a
*-core.test.tsfile can run on its own (added for #306).
How to check
Run ./scripts/check_application.sh tests/app/search.test.ts, a missing path, and the script without arguments (set FLUX_TEST_PORT/FLUX_TEST_MAILPIT_PORT if the defaults are taken). Then python3 scripts/check_agent_setup.py, python3 -m unittest discover -s tests -p 'test_*.py', git diff --check.
New to Flux? Start with CONTRIBUTING. Comment here to say you are taking it.
- Dominant language
- TypeScript
- Stars
- 3
- Forks
- 0
- Avg merge
- 22h 53m
- Merged PRs (30d)
- 272
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ColdPhase/flux
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 8/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
QuantumNous/new-api#7839 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
bug p2 triaged
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
getpaseo/paseo#7071 · 1 comment ·
Maintainers usually reply within 1 day
-
test: make the #3408 Claude OAuth token fixture obviously fake so secret scanners stop flagging itOpen
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
code-yeongyu/senpi#3436 ·
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 78/100
lingdojo/kana-dojo#32505 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day