Improvement: Transposing tabs with string adjustments.
Maintainers usually reply within 1 day
@Danielku15 is already working on this.
Since Jul 17, 2024.
Assessment
This issue has not been assessed yet.
Description
Is there an existing issue for this?
- I have searched the existing issues
Current Behavior
I'm experiencing issues with the transposition feature not working as expected. When I set transpositionPitches: [-4], the notes incorrectly go below 0. Instead, they should move up a string rather than displaying a -1.
Steps to Reproduce:
- Open the attached guitar tab file with no transposition applied (see Screenshot 1).
- Set
transpositionPitchesto[-4]. - Observe the transposed guitar tab (see Screenshot 2).
Expected Behavior:
The notes should transpose correctly by moving up a string instead of displaying a negative value, as demonstrated in the expected output from Songsterr (see Screenshot 3).
Screenshots:
-
No transposition applied:
-
After Setting
transpositionPitchesto[-4]:
-
Expected Transposition Output - Screenshot from Songsterr for the same tab:
Expected Behavior
The notes should transpose correctly by moving up a string instead of displaying a negative value, as demonstrated in the expected output from Songsterr (see Screenshot 3 above).
Steps To Reproduce
-
Download the GP File:
- Download the file 58202729.gp.zip.
-
Set the Transposition:
- Open the downloaded file and set
transpositionPitchesto[-4].
- Open the downloaded file and set
-
Observe the Issue:
- You will notice that the notes incorrectly move below 0, displaying negative values.
-
Compare with Songsterr:
- Access the tab on Songsterr: Ed Sheeran - Love Can Hurt Tab to see the correct transposition.
Link to jsFiddle, CodePen, Project
No response
Found in Version
1.4 (alpha)
Platform
Web
Environment
- **OS**:
- **Browser**:
- **.net Version**:
Anything else?
No response
- Dominant language
- TypeScript
- Stars
- 1.9k
- Forks
- 297
- Avg merge
- 9h 2m
- Merged PRs (30d)
- 44
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CoderLine/alphaTab
-
ai-authored
Difficulty 2/5 1-3 hours Newbie friendliness 69/100
Maintainers usually reply within 1 day
-
ai-authored
Difficulty 3/5 1-2 days Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
Respect systems layout of MusicXMLPossibly taken @Danielku15 claimed this 21 days ago. Open
CoderLine/alphaTab#2909 · 1 assignee ·
Maintainers usually reply within 1 day
-
Expose Lyrics in public apiPossibly taken @Danielku15 claimed this 21 days ago. Open
CoderLine/alphaTab#2908 · 1 assignee ·
Maintainers usually reply within 1 day
-
Show accentuations on tab-only stavesPossibly taken @Danielku15 claimed this 21 days ago. Open
CoderLine/alphaTab#2906 · 1 comment · 1 assignee ·
Maintainers usually reply within 1 day
All issues in CoderLine/alphaTab
Similar issues
-
ready
Difficulty 2/5 1-3 hours Newbie friendliness 63/100
wheresrhys/totf#1214 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
CodeChefVIT/ffcs#281 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
endora-commerce/endora-commerce#451 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
vetro-protocol/vetro-monorepo#1007 ·
Maintainers usually reply within 1 day