Fixed dependency warnings stay open when the upgrade is in a version catalog, Directory.Packages.props, Package.resolved and similar files
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust, typescript
Research direction
Start with isDependencyManifest in packages/engine/src/scan/fixcheck.ts and compare its list with the formats the indexer reads in crates/indexer/src/deps/formats.rs. The consumers are affectedFindings in apps/web/src/server/scans.ts and changesDependencies in apps/web/src/server/webhooks.ts. Done means the missing files (libs.versions.toml, Package.resolved, pdm.lock, .gitmodules and the others listed) are recognised, and a test fails if the indexer gains a format the check does not know about.
Written by the indexing model from the issue text.
Description
Hi! I found a gap between what Sandchest reads and what it watches.
What happens
When I upgrade a vulnerable library in some dependency files, Sandchest doesn’t notice the upgrade. The warning stays open even though the problem is fixed, and the CVE directory keeps the old version.
Why
The indexer reads dependencies from these files (crates/indexer/src/deps/formats.rs). But isDependencyManifest in packages/engine/src/scan/fixcheck.ts decides whether a push “changed dependencies”, and its list is shorter. So when a push only touches one of the missing files:
affectedFindings (apps/web/src/server/scans.ts) skips re-checking the open vulnerable_dependency findings.
changesDependencies (apps/web/src/server/webhooks.ts) skips refreshing the dependency inventory.
Files the indexer reads but the check misses
libs.versions.toml (Gradle version catalogs, common in Android/Kotlin)
Directory.Packages.props, packages.config, *.fsproj, .vbproj (.NET)
Package.resolved (Swift)
pdm.lock (Python)
rebar.lock (Erlang), Manifest.toml (Julia), renv.lock (R)
cabal.project.freeze, stack.yaml.lock (Haskell), opam.locked (OCaml)
.gitmodules, .github/workflows/.yml
Steps to reproduce
Use a Gradle project that keeps versions in gradle/libs.versions.toml, with a library that has a known CVE.
Let Sandchest report the vulnerable dependency.
Push a commit that only bumps that library’s version in libs.versions.toml.
The finding stays open.
Expected
Any file the indexer reads dependencies from should count as a dependency change.
Suggested fix
Add the missing file names to isDependencyManifest. Also add a test that lists every file the indexer supports, so the two lists can’t drift apart again.
Happy to open a PR for this if it sounds good.
- Dominant language
- TypeScript
- Stars
- 57
- Forks
- 8
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
SocialGouv/egapro#5212 ·
Maintainers usually reply within 2 days
-
area:filesystem bug need-triage
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
Captions panel does not offer to show an existing transcriptPossibly taken @thedavidweng claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
CapSoftware/Cap#4276 · 1 comment ·
Maintainers usually reply within 1 day
-
bug from-app needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
nightly-labs/openbot#10242 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day