Fixed dependency warnings stay open when the upgrade is in a version catalog, Directory.Packages.props, Package.resolved and similar files

Aberta
#3 0 comentários 0 reações 0 responsáveis Ver no GitHub

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
3/5
Tempo estimado
Meio dia
Facilidade para iniciantes
72/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
rust, typescript
Domínio
devtools, security

Direção de pesquisa

Start with isDependencyManifest in packages/engine/src/scan/fixcheck.ts and compare its list with the formats the indexer reads in crates/indexer/src/deps/formats.rs. The consumers are affectedFindings in apps/web/src/server/scans.ts and changesDependencies in apps/web/src/server/webhooks.ts. Done means the missing files (libs.versions.toml, Package.resolved, pdm.lock, .gitmodules and the others listed) are recognised, and a test fails if the indexer gains a format the check does not know about.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Hi! I found a gap between what Sandchest reads and what it watches.

What happens

When I upgrade a vulnerable library in some dependency files, Sandchest doesn’t notice the upgrade. The warning stays open even though the problem is fixed, and the CVE directory keeps the old version.

Why

The indexer reads dependencies from these files (crates/indexer/src/deps/formats.rs). But isDependencyManifest in packages/engine/src/scan/fixcheck.ts decides whether a push “changed dependencies”, and its list is shorter. So when a push only touches one of the missing files:

affectedFindings (apps/web/src/server/scans.ts) skips re-checking the open vulnerable_dependency findings.
changesDependencies (apps/web/src/server/webhooks.ts) skips refreshing the dependency inventory.

Files the indexer reads but the check misses

libs.versions.toml (Gradle version catalogs, common in Android/Kotlin)
Directory.Packages.props, packages.config, *.fsproj, .vbproj (.NET)
Package.resolved (Swift)
pdm.lock (Python)
rebar.lock (Erlang), Manifest.toml (Julia), renv.lock (R)
cabal.project.freeze, stack.yaml.lock (Haskell), opam.locked (OCaml)
.gitmodules, .github/workflows/
.yml

Steps to reproduce

Use a Gradle project that keeps versions in gradle/libs.versions.toml, with a library that has a known CVE.
Let Sandchest report the vulnerable dependency.
Push a commit that only bumps that library’s version in libs.versions.toml.
The finding stays open.

Expected

Any file the indexer reads dependencies from should count as a dependency change.

Suggested fix

Add the missing file names to isDependencyManifest. Also add a test that lists every file the indexer supports, so the two lists can’t drift apart again.

Happy to open a PR for this if it sounds good.

Linguagem predominante
TypeScript
Estrelas
57
Forks
8
Métricas de merge de PRs
Nenhum PR com merge em 30d

Preparar o ambiente

Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.