allow for non-complete emodels

Open
#207 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
30/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend

Research direction

Start in bluepymm/prepare_combos/create_mm_sqlite.py around line 365, where missing emodels cause the crash. Read the surrounding check and the configuration handling, then determine how the proposed option should control incomplete emodels. Done means the process handles missing emodels without crashing when the option is enabled, while preserving the existing check otherwise.

Written by the indexing model from the issue text.

Description

If there are some missing emodels for some etypes, this is crashing:

https://github.com/BlueBrain/BluePyMM/blob/master/bluepymm/prepare_combos/create_mm_sqlite.py#L365

Maybe we could add an option from config to allow for non-complete emodels, and do:
morph_fullmtype_etype_map = morph_fullmtype_etype_map.dropna()
before the check.

Dominant language
Python
Stars
13
Forks
9
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from BlueBrain/BluePyMM

All issues in BlueBrain/BluePyMM

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.