Layer reading is wrong in circuit mvd3 branch

Open Beginner friendly
#177 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
data

Research direction

Start by reading bluepymm/prepare_combos/parse_files.py at line 158 and inspect how the layer is currently read. Compare that logic with circuitmvd3_file['library']['layer']; the work is done when layer values come from the MVD3 file's layer mapping.

Written by the indexing model from the issue text.

Description

bug

As mentioned by @wizmer, the layer is not read correctly in:
https://github.com/BlueBrain/BluePyMM/blob/read_mvd3_dontmerge/bluepymm/prepare_combos/parse_files.py#L158

It needs to use the layer mapping in the mvd3 file at
circuitmvd3_file['library']['layer']

Dominant language
Python
Stars
13
Forks
9
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from BlueBrain/BluePyMM

All issues in BlueBrain/BluePyMM

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.