ADR 0005 slice 5: fold style-only single-child boxes into their child

Open
#6,240 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
php
Domain
backend

Research direction

Start by reading ADR 0005 (#6160) and slice 4 (#6239), then inspect the classifier and parity checks for the Wix capture. Implement the geometry-proven fold rules and add the requested table-driven contract test with one fold and one refusal per rule. Done means reporting per-route fold counts, meeting the depth and groups-per-leaf targets, and preserving desktop and mobile parity with slice 4.

Written by the indexing model from the issue text.

Description

Slice 5 of ADR 0005 (#6160). Depends on slice 4 (https://github.com/Automattic/blocks-engine/issues/6239).

Goal: fold single-child boxes that are load-bearing only because of their own styles into that child, proved by geometry. Once the engine owns every rule (slice 3), moving a declaration is safe, because no author selector depends on the box.

Fold rules: each applies only when the box has exactly one child, no semantics, references, interaction or motion, and the result is proved at every captured viewport:

  • Own sizing (padding): the box's padding becomes the child's margin when the child is block-level, has no margin on that side, and the child's border box sits exactly inside the box's padding edge. Sizing constraints (width, max-width, min-height) move only when the child's used size is already equal.
  • Paint: background, border, radius or shadow moves to the child when the child's border box equals the box's border box and the child doesn't paint on those properties.
  • Containing block: position:relative moves to the child when every positioned descendant's offsets resolve to the same rectangle (the child's border box equals the box's).
  • Never fold: clipping, multi-child layout, semantic tags, transforms, filters or opacity (they create stacking contexts), or pseudo-elements that render.

Measured today (classifier on the Wix capture, structural boxes): Home 258 (109 neutral; 38 own-sizing, 21 paint, 22 containing-block). About 110 (44 neutral; 16, 10, 5). The ceiling after slice 5 is about 68 structural boxes on Home, roughly 70% fewer wrappers.

Acceptance:

  • Report the fold count per rule per route, plus emitted depth and groups per leaf. The ADR targets are depth ≤ 10 and groups per leaf ≤ 1.1.
  • Desktop and mobile parity against slice 4 shows no regression.
  • One table-driven contract test, with one fold and one refusal per rule.

AI disclosure: written by Franklin (Claude Opus via Pi, Roadie).

Dominant language
PHP
Stars
28
Forks
5
Avg merge
2h 59m
Merged PRs (30d)
942

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Automattic/blocks-engine

All issues in Automattic/blocks-engine

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.