ADR 0005 slice 4: collapse neutral boxes on engine-styled routes
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 40/100
Research direction
Read ADR 0005 (#6160), then inspect HtmlCompilation and how it consumes the classifier's per-node disposition on engine-styled routes. Check the slice 3 result and the box-tree v2 dependency (#6238) before changing the emission path. Done means a neutral chain collapses, a painting sibling remains, the reported group counts and depth metrics meet acceptance, and desktop/mobile parity has no regression.
Written by the indexing model from the issue text.
Description
Slice 4 of ADR 0005 (#6160). Depends on slice 3 (#6233, PR #6236) and box-tree v2 (#6238).
Goal: on routes where the engine owns the styles, a source box classified as neutral (equal-child-geometry: same border box as its only child at every captured viewport, no paint, clip, multi-child layout, containing block, semantics or interaction) emits no block. Its child takes its place in the parent.
Design:
- Decide in
HtmlCompilationbefore the wrapper turns into acore/group. The classifier's per-node disposition is the only authority; the existingWrapperCoalescerselector-survival heuristic doesn't apply on evidence routes, because no author selectors ship. - The child keeps its own engine rule. The removed box's rule is dropped, since its geometry equals the child's by construction.
- Routes without evidence are untouched.
Acceptance (sdnunca Lab capture):
- Emitted
core/groupcount per route drops by at least the neutral structural boxes the classifier reports (Home 109, About 44 ontrunktoday). - Report max group depth and groups per leaf, measured on emitted blocks.
- Desktop and mobile parity against the slice 3 result shows no regression.
- One contract test: a fixture with a neutral chain collapses, and a sibling that paints is kept.
AI disclosure: written by Franklin (Claude Opus via Pi, Roadie).
- Dominant language
- PHP
- Stars
- 28
- Forks
- 5
- Avg merge
- 2h 59m
- Merged PRs (30d)
- 942
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Automattic/blocks-engine
-
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
Automattic/blocks-engine#6318 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Automattic/blocks-engine#4943 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Automattic/blocks-engine#4942 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Automattic/blocks-engine#4921 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Automattic/blocks-engine#775 ·
Maintainers usually reply within 1 day
All issues in Automattic/blocks-engine
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
TYPO3-Solr/ext-solr#4850 ·
Maintainers usually reply within 2 days
-
[Sync EN] stream: document the errors of the stream_context_*() and stream filter functions (#6091)Opensync-en
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
[Sync EN] stream: document the errors of the stream_context_*() and stream filter functions (#6091)Opensync-en
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
Maintainers usually reply within 1 day
-
Перевод устарел
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
glpi-project/glpi#26353 · 2 comments ·
Maintainers usually reply within 1 day