dmft and Hirsch-Fye: define their parameters on alps::params like CT-INT and CT-HYB

Open
  • Is something wrong?
#286 0 comments 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 3 days

@Ooolab is already working on this.

Since Nov 2, 2026.

Assessment

This issue has not been assessed yet.

Description

area:dmft enhancement

The CT-INT (interaction) and CT-HYB (hybridization) solvers declare their parameters on ALPSCore's alps::params with define, each with its type, default and description, and report missing and unused keys. The dmft driver and the Hirsch-Fye solver (hirschfye, and dmft with SOLVER = Hirsch-Fye) still read the legacy alps::Parameters, with defaults given at each read through value_or_default.

So DMFT input reaches two kinds of programs:

  • An unknown or misspelled key is reported by CT-INT and CT-HYB, and ignored by dmft and Hirsch-Fye.
  • A new input format (TOML, for example) has to feed both alps::params and alps::Parameters.

Proposal

Have dmft and Hirsch-Fye define their keys on alps::params, as define_parameters does for CT-INT and CT-HYB. Their parameter readers (alps/input/dmft.hpp and alps/input/hirschfye.hpp on marcusr2ML/ALPS upstream-dmft-input) would then read the defined alps::params. The driver's internal classes (Hilbert and Fourier transformers, band structure, external solver) can keep receiving alps::Parameters through alps::make_deprecated_parameters.

Dominant language
C++
Stars
32
Forks
10
Avg merge
4d 5h
Merged PRs (30d)
52

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ALPSim/ALPS

All issues in ALPSim/ALPS

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.