Planner rewrites skip reasons when lenses are empty

Open Beginner friendly
#71 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
typescript

Research direction

Start with src/pipeline/planner.ts:1422-1428 and the component spec at specs/project/components/review_pipeline.md:455. Check how a skipped planner result with a valid reason and empty lenses is handled, then confirm the packet-builder log preserves the reason. Done when empty lenses no longer cause that reason to be rewritten or default lenses to be added; verify the behavior against the cited spec.

Written by the indexing model from the issue text.

Description

bug

Problem: A planner skip with a valid reason and empty lenses has its reason rewritten to planner_empty_lenses: ... and default lenses are added. The hunk remains skipped, but the original diagnostic reason required by the component spec is lost.
File:line: src/pipeline/planner.ts:1422-1428; specs/project/components/review_pipeline.md:455.
Evidence: Schema accepts lenses: [] on a skip with valid reason; @architect-2 confirmed the reason is altered before packet-builder logs it.
Suggested fix size: S.
Found during #44 (workstream U, confirmed by @architect-2).

Dominant language
TypeScript
Stars
8
Forks
1
Avg merge
5m
Merged PRs (30d)
2

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from 0xPolygon/codegenie

All issues in 0xPolygon/codegenie

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.