New bug in ApplyTemplate method after V2.1.0 released
还没有人认领这个 Issue。
评估
调研方向
Start at ApplyTemplate(Stream templateStream, bool includeContent) and reproduce the failure with the provided code using a DOCX containing an empty paragraph. Read the Paragraphs collection behavior and paragraph.Remove(false), especially RemoveParagraphFromCache; done means ApplyTemplate with includeContent set to false completes without InvalidOperationException.
由索引模型根据 Issue 内容生成。
描述
Hello,
My old code stopped working after I updated nuget package from V2.0.0 to V2.3.0. The reason is that ApplyTemplate( Stream templateStream, bool includeContent ) method now throws an System.InvalidOperationException when includeContent is set to false because of those reasons:
if( !includeContent )
{
foreach( Paragraph paragraph in this.Paragraphs )
{
paragraph.Remove( false );
}
}
In this part of ApplyTemplate method paragraph.Remove( false ); modifies Paragraphs collection, and this causes foreach-loop to break. This is happening because in V2.1.0 (commit 9c431afb) realization of Paragraphs collection was changed and now there is underlying List<Paragraph> _editableParagraphsCollection list which is modified when paragraph.Remove( false ); calls RemoveParagraphFromCache( paragraph );
The code to reproduce the bug is as simple as that:
using (var document = DocX.Create("test.docx"))
{
using (var templateStream = new FileStream("template.docx", FileMode.Open, FileAccess.Read))
{
document.ApplyTemplate(templateStream, false);
}
document.Save();
}
where template.docx is any docx created in MS Word, because even empty document includes one empty paragraph. I'm not sure which is the most accurate way to fix this issue.
- 主要语言
- C#
- 星标
- 1.9k
- 派生
- 482
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
xceedsoftware/DocX 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 48/100
xceedsoftware/DocX#489 · 1 条评论 ·
-
难度 4/5 3-5 天 新手友好度 35/100
xceedsoftware/DocX#488 · 1 条评论 · 1 个 reaction ·
-
keep format未关闭
难度 3/5 1-2 天 新手友好度 25/100
xceedsoftware/DocX#487 · 3 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 45/100
xceedsoftware/DocX#485 · 1 条评论 ·
-
难度 4/5 3-5 天 新手友好度 25/100
xceedsoftware/DocX#482 · 4 条评论 ·
查看 xceedsoftware/DocX 的全部 Issue
相似的 Issue
-
area:jobads-cv BE P3
难度 1/5 1-3 小时 新手友好度 74/100
klasolsson81/jobbliggaren#2240 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
k2-fsa/sherpa-onnx#4100 ·
维护者通常 2 天内回复
-
:watch: Not Triaged
难度 1/5 1 小时以内 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
unoplatform/uno.check#591 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
weaviate/csharp-client#378 ·