spdx-tools: latest tag is published without any tests

未关闭
#462 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

@officialasishkumar 已经在做这个了。

开始于 2026年11月19日。

  • #463 来自 @officialasishkumar —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
停滞
技术栈
docker, json

调研方向

Compare the other images' test directories and tag dependencies with images/spdx-tools/main.tf. Add the smoke checks described for Version, nonroot execution, Verify, and Convert, and document the image in the top-level README. Done when the tests gate the latest tag and the README covers the image; pull request #463 is already open against this work.

由索引模型根据 Issue 内容生成。

描述

images/spdx-tools is the only image in this repo whose latest tag isn't gated on a test. Every other module (alpine-base, apko, busybox, gcc-musl, git, musl-dynamic, sdk, static) runs oci_exec_test checks against the freshly built digest and makes its oci_tag resource depends_on them. spdx-tools/main.tf just tags whatever apko produced:

resource "oci_tag" "version-tags" {
  digest_ref = module.latest.image_ref
  tag        = "latest"
}

So if the image builds but doesn't work, for example because of a JRE packaging change, a broken spdx-tools-java launcher, or a nonroot permission problem, the nightly release job still moves ghcr.io/wolfi-dev/spdx-tools:latest to it, and nobody notices until a user hits it. Presubmit doesn't catch it either, because there's nothing to run.

The image also isn't mentioned in the top-level README, and it has no README of its own, unlike the other images.

Proposed fix:

  • add images/spdx-tools/tests with smoke tests that check Version, the nonroot user, Verify on a valid SPDX JSON document, a JSON to tag-value Convert (and verifying the result), and that Verify rejects an invalid document
  • make the latest tag depend on those tests, the same way the other images do
  • document the image in the README
主要语言
HCL
星标
31
派生
25
平均合并
2 天 22 小时
30 天内合并 PR
19

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

wolfi-dev/tools 的其他 Issue

查看 wolfi-dev/tools 的全部 Issue

相似的 Issue

更多 DevOps Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。