Define byte-cursor output aliasing with cursor state

未关闭
#1,037 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
38/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
rust
领域
compilers

调研方向

Start with std/bytes/read.wave:40, then locate the read and peek cursor-output variants and their tests. Before implementation, get the required design discussion with @LunaStev to decide whether cursor outputs may alias position, length, or backing storage. Done means the approved rule is documented for all alias cases, existing success and rollback behavior remains intact, and read/peek variants apply the same rule without per-width duplication.

由索引模型根据 Issue 内容生成。

描述

discussion enhancement help wanted

Motivation

Passing &reader.position as the u64 output of a valid eight-byte read returns success and leaves position=28 for len=8 when the decoded value is 20. O0/O2 agree. The API does not state whether output may overlap cursor state, and cannot simultaneously preserve two meanings for the same bytes.

Starting point: std/bytes/read.wave:40.

Validation

Audited canonical Wave 540728c2eb6cc12f5c69c3fb3fdb96e07ba059a4 (0.0.1-alpha-dev), whose tree matches the local checkout. Validation: Executed valid-memory output/state alias fixture at native O0/O2. Executed compiler probes use the matching checkout-built compiler and std on Linux amd64 (Rust 1.89.0 / LLVM 21.1.8). Source/header or mocked checks are not native execution on another OS.

Scope

Choose explicit non-aliasing or checked-overlap rules for cursor outputs/state/backing storage. Do not promise arbitrary alias support or call this a Rust memory-safety defect.

Related: #674, #763. These links do not claim those broader or completed scopes are unfinished.

Design discussion required

This issue records a proposal or an unresolved contract; it is not approval to choose new semantics. Please mention @LunaStev to discuss the design before starting implementation.

Completion criteria

  • The position/len/data alias cases have documented permitted or rejected behavior.
  • Normal outputs and failure rollback keep their existing results.
  • Read and peek variants apply the same approved rule without duplicating one cause per integer width.
主要语言
Rust
星标
56
派生
21
平均合并
23 小时 20 分钟
30 天内合并 PR
45

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

wavefnd/Wave 的其他 Issue

查看 wavefnd/Wave 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。