Readiness probe can't pass Access on a Custom-Domain-only Worker
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- typescript
- 领域
- devops
调研方向
Start in packages/deploy-cloudflare/src/version.ts at the readiness probe and guardedReadinessHeaders locations cited in the issue; compare the staged custom-route and first-deploy bootstrap paths with the existing test that prevents credentials from leaking to custom routes. Decide how the probe can authenticate safely for a Custom-Domain-only Worker, then add coverage for that behavior. Done means staged deploys can verify readiness with the intended Access setup while preserving the existing credential-scope protections.
由索引模型根据 Issue 内容生成。
描述
Thanks for Void! I ran into what looks like a gap in the staged deploy flow.
Summary
If a Worker is served only on a Custom Domain behind Cloudflare Access (workers_dev: false, preview_urls: false), a staged void deploy can't pass the readiness probe. Access credentials are only sent to workers.dev hosts, so Access blocks the probe and the deploy rolls back. The error suggests setting CF_ACCESS_CLIENT_ID / CF_ACCESS_CLIENT_SECRET, but on this path they aren't sent.
Use case
I'm deploying an internal dashboard that only staff should reach. All our internal tools live under *.internal.example.com, and one wildcard Access application in front of that hostname applies the same SSO policy to every tool. The app also checks the Access JWT's audience, so it only trusts that one application.
I turned off workers_dev and preview_urls so the Worker has exactly one way in. A workers.dev URL is outside the wildcard. It would need its own Access application, with a second policy to keep in sync and a different audience for the app to accept. Without one, the app is public. Cloudflare recommends a route or Custom Domain over workers.dev for production Workers, so this seemed like the expected setup.
Repro
// void.config.ts
export default defineConfig({
cloudflare: {
routes: [{ pattern: 'dashboard.internal.example.com', custom_domain: true }],
workers_dev: false,
preview_urls: false,
},
})
- Protect
*.internal.example.comwith an Access application whose policy admits a service token. - Set
CF_ACCESS_CLIENT_IDandCF_ACCESS_CLIENT_SECRETto that token. - Run
void deploy --platform cloudflareon a Worker that already has a deployed version.
deploy: Cloudflare Access blocked the uploaded Worker Version readiness probe.
For CI, set CF_ACCESS_CLIENT_ID and CF_ACCESS_CLIENT_SECRET to an admitted service token.
The same credentials work when sent manually:
curl -H "CF-Access-Client-Id: $CF_ACCESS_CLIENT_ID" \
-H "CF-Access-Client-Secret: $CF_ACCESS_CLIENT_SECRET" \
https://dashboard.internal.example.com/__void/ready
# {"ready":true,"versionId":"..."}
What I found
With no preview URL, activateCloudflareVersion stages the new version at 0% and probes the custom route with Cloudflare-Workers-Version-Overrides, but leaves the Access headers off:
version.ts#L1340:readinessUsesCustomRoute ? undefined : options.readinessHeadersversion.ts#L2492:guardedReadinessHeadersonly accepts<worker>.<subdomain>.workers.dev- The first-deploy bootstrap path does the same:
version.ts#L2126
This looks intentional. 6ea0b4699 added a test asserting the headers are not sent to a custom route ('must-not-leak'), which makes sense, since a route hostname isn't guaranteed to reach this Worker. The side effect is that a Custom-Domain-only Worker has no hostname where the probe can authenticate.
Workaround: --atomic (or deploy.cloudflare.mode: "atomic"). It deploys, but skips the pre-traffic check and exits with "the atomic Worker deployment is live, but /__void/ready could not be verified".
Possible directions
Not sure which fits Void's security model best, so here are the options I could see:
- Opt-in origin. Let the user name one origin that may receive the readiness credentials, similar to how
VOID_ACCESS_ORIGINscopes platform credentials. With nothing set, the current behavior stays the same. - Custom Domains automatically. Send the headers when the probe host comes from a
custom_domain: trueroute. One caveat: per Cloudflare's docs, a Route on the same hostname takes precedence over a Custom Domain, so this may need a route check first. - Error message only. For a custom-route probe, point to
--atomicinstead ofCF_ACCESS_CLIENT_*.
Happy to put together a PR if one of these sounds right.
void 1.2.1, @void/deploy-cloudflare 1.2.1. The same code is still on main (246e186, after v1.3.0).
- 主要语言
- TypeScript
- 星标
- 580
- 派生
- 56
- 平均合并
- 11 小时 32 分钟
- 30 天内合并 PR
- 158
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
voidzero-dev/void 的其他 Issue
-
难度 5/5 一周以上 新手友好度 42/100
voidzero-dev/void#638 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 57/100
voidzero-dev/void#636 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 67/100
voidzero-dev/void#635 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 48/100
voidzero-dev/void#627 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 35/100
voidzero-dev/void#606 ·
维护者通常 1 天内回复
查看 voidzero-dev/void 的全部 Issue
相似的 Issue
-
Parallel reticle_verify opens per-flow leases without the source lease's ignoreHTTPSErrors可能已有人在做 @as992949791 今天认领。 未关闭good first issue help wanted
难度 2/5 1-3 小时 新手友好度 85/100
reticlehq/reticle#2033 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
area:quality p3-medium ready-for-agent type:docs
难度 2/5 1-3 小时 新手友好度 83/100
fderuiter/deruiter.dev#3589 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
manfredsteyer/angular-oauth2-oidc#1514 ·
-
难度 2/5 1-3 小时 新手友好度 76/100
marmelab/react-admin#11431 ·
维护者通常 1 天内回复