A miss on a fresh checkout runs `tsc --incremental` with no build info, though the step's entry archived it

未关闭
#936 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
rust, typescript

调研方向

Start with the cache restore path in crates/vt/src/session/cache/mod.rs, especially ExecutionCache::restore and the remote validation path at lines 446–451. Then read crates/vt/src/session/execute/cache_update.rs to see how task outputs are recorded. Implementing this spans local and remote archives, missing-file handling, and modification times; done means a task can opt in to restoring a missing listed file on a cache miss while existing behavior remains intact.

由索引模型根据 Issue 内容生成。

描述

Written by an AI agent (Claude) on behalf of @jasonkuhrt.

Part of the work in #929. Since #913, a task that rewrites its tool cache, such as tsc --incremental with tsconfig.tsbuildinfo, is cached, and a hit restores that file with the task's other outputs. A miss restores nothing, so on a fresh checkout, which is where CI runs, every miss starts the tool cold.

What happens
// vite.config.ts
import { defineConfig } from 'vite-plus';

export default defineConfig({
  run: {
    tasks: {
      'check:types': { command: 'tsc --incremental --noEmit' },
    },
  },
});
  1. A run on main executes check:types. tsc writes tsconfig.tsbuildinfo, and the entry archives it as an output.
  2. A pull request edits src/a.ts. CI checks out a fresh tree, so there's no build info on disk. The entry under the step's cache key fails validation ('src/a.ts' modified), so it's a miss.
  3. tsc runs with no build info and checks every file. The entry's archive holds the build info from step 1, but only a hit extracts it (ExecutionCache::restore, crates/vt/src/session/cache/mod.rs:589 at c4b2aacf). For a remote entry, a failed validation also means its archive is never downloaded (mod.rs:446-451).

With incremental compilation enabled, TypeScript records each input's content version in its build info, so the next compilation can skip what hasn't changed (incremental).

The ask

A per-task list of tool cache files that a miss restores from the entry under the step's cache key, before the command runs:

'check:types': {
  command: 'tsc --incremental --noEmit',
  cache: { restoreOnMiss: ['tsconfig.tsbuildinfo'] },
},

The name is only a suggestion.

Which files qualify
  • Only a cache the tool validates itself. Listing a file says the command's result is the same with or without it. A cache whose keys can miss a change, such as a transform cache keyed by a module's text alone, doesn't qualify. The runner can't tell the two apart, so this is opt-in per file.
  • Not an emitting build. An emitting build's build info vouches for its emitted files, and TypeScript emits only the files it finds affected. Build info restored beside missing or older outputs would leave them wrong, and restoring the two together would need all-or-nothing rules this ask doesn't cover. That's why the example is --noEmit.
Where the copy comes from

The entry under the step's current cache key (same command, env and cache config):

  • A local entry: the listed files are extracted from its archive in the cache directory.
  • A remote entry: its archive is downloaded and the listed files are extracted. Only a task that lists files pays for that download.
  • A remote fallback names another key and carries no archive, so it restores nothing.
  • No entry under the key in either tier, as on a first run: nothing is restored, and the command runs as it does today.
When a file is restored
  • Only when it's missing, which is the fresh-checkout case. A file already on disk is the tool's latest state, possibly from a run that failed and so stored no entry (crates/vt/src/session/execute/cache_update.rs:90-91), and is left alone.
  • With its archived modification time, as a hit's outputs are today. tsc --build's up-to-date check compares modification times, so build info dated at restore can make changed inputs look up to date there. #881 proposes dating a hit's outputs when they land; a file restored on a miss needs its archived time either way.
  • Never at the task's expense: a listed file the archive doesn't hold, or a restore that fails, leaves the command to run as it does today.
What the run records
  • A listed file counts as one the run wrote. It's archived from disk after the run and recorded as possibly missing, as #913 records a file a task rewrites, even when this run only read it. Otherwise a run that reads the build info without rewriting it would store an entry that requires the file and holds no copy of it.
  • A positive cache.input glob that matches a listed file keeps its meaning today: it's hashed before the run.
What stays the same
  • A hit restores every output, the listed files included.
  • --dry-run (#933, proposed) downloads and restores nothing, so this changes no status it reports.
Alternatives considered
  • Restore every file a task rewrites. That includes caches that can change the result, and the runner can't tell which those are.
  • CACHEDIR.TAG (#793). A tag says a directory is a cache, not that its tool validates it, so it can't opt a directory into this. A tool that tags its cache could still list it here.
  • The CI provider's cache (GitHub's actions/cache, a runner's persistent disk). It needs the path and a key per job and per provider, outside the task graph, while Vite Task already holds the file in the step's entry.
Our case

We restore build info today with a wrapper around each type-check command: it fetches the branch's last build info from our own server before tsc runs and stores it after. With this, Vite Task would restore it from the entry it already holds, and the wrapper's restore and store would go. Our pnpm layout also needs the build info's dependency paths rewritten for the machine, which stays on our side.

主要语言
Rust
星标
485
派生
51
平均合并
23 小时 20 分钟
30 天内合并 PR
56

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

voidzero-dev/vite-task 的其他 Issue

查看 voidzero-dev/vite-task 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。