`preserve=yes` needs to skip remove scriptlets.
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 55/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 冷清
- 技术栈
- c
- 领域
- cli, operating-systems
调研方向
Start by reviewing the preserve=yes handling in xbps-remove and the behavior introduced by commit c11dba09d7389896cd50f35bf57150542a707da. Trace both remove and purge scriptlet stages, then verify that preserved packages skip removal scriptlets while retaining the existing kernel-safety behavior.
由索引模型根据 Issue 内容生成。
描述
In https://github.com/void-linux/xbps/commit/c11dba09d7389896cd50f35bf57150542a707da5 the behavior of preserve=yes packages was changed to behave the same on explicit removal and update, in both cases files are now preserved. This is done so that xbps-remove does not circumvent vkpurge and its "is this kernel booted" check before uninstalling the kernel files.
But currently the remove scripts still run on explicit removal, instead the remove script should probably be completely skipped if the package was build with preserve=yes.
There is currently two stages in the remove scriptlets, remove and purge, they usually just run one after another and don't really have any use. I thought about removing the purge stage before, because every extra script execution just adds overhead without any real benefit.
It might make sense to to keep both stages and make use of that differentiation for the preserve=yes scripts, but I'm not convinced that it would actually be beneficial, especially because preserve=yes is really only used for kernels.
- 主要语言
- C
- 星标
- 1.2k
- 派生
- 152
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
void-linux/xbps 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 68/100
void-linux/xbps#475 ·
-
难度 4/5 3-5 天 新手友好度 45/100
void-linux/xbps#701 ·
-
难度 4/5 3-5 天 新手友好度 55/100
void-linux/xbps#700 ·
-
bug
难度 3/5 1-2 天 新手友好度 45/100
void-linux/xbps#696 ·
-
难度 3/5 1-2 天 新手友好度 52/100
void-linux/xbps#695 · 7 条评论 ·
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 68/100
fastfetch-cli/fastfetch#2628 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
FujiNetWIFI/fujinet-firmware#1736 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 3 天内回复
-
难度 2/5 1-3 小时 新手友好度 86/100