test : add unit tests for _check_field helper in validation

未关闭
#2,337 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

  • #2342 来自 @tmdeveloper007 —— 已关闭,未合并

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
35/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
停滞
技术栈
fastapi, python
领域
testing

调研方向

Read backend/secuscan/validation.py and follow _check_field's string, list, and other-value paths. Add testing/backend/unit/test_validation_check_field.py with the listed boundary, pass-through, and error-message cases, using settings for limits. Run the new unit tests and confirm they cover each case; issue #2342 has a closed, unmerged pull request, so check its changes before starting.

由索引模型根据 Issue 内容生成。

描述

Summary of What Needs to be Done:
Add unit tests for the _check_field helper function in backend/secuscan/validation.py. This private function validates individual input field values (strings and lists) against length limits. It is the core of the validate_task_start_payload function and has distinct logic paths for string vs list values.

Changes that Need to be Made:

  • Add a new file testing/backend/unit/test_validation_check_field.py
  • Import _check_field and settings from backend.secuscan.validation
  • For string values:
    • Test string at exactly max length passes
    • Test string exceeding max length returns 400 with appropriate message
    • Test string well under limit passes
  • For list values:
    • Test list at exactly max array length passes
    • Test list exceeding max array length returns 400
    • Test list with items exceeding max field length returns 400
    • Test list with all items within limits passes
  • For non-string/non-list values:
    • Test returns (True, 0, '') for unexpected types (pass-through)
  • Test that error messages do not echo back field values
  • Test with edge case: empty string ("") passes
  • Test with edge case: empty list ([]) passes

Impact that it would Provide:

  • Provides granular coverage for the field-level validation logic
  • Ensures string length and array length limits are enforced correctly
  • Guards against regression as settings limits are adjusted

Note: This task is being handled by tmdeveloper007 — please assign to that account when picking it up.

主要语言
Python
星标
36
派生
234
PR 合并指标
30 天内没有已合并 PR

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

utksh1/SecuScan 的其他 Issue

查看 utksh1/SecuScan 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。