test : add unit tests for _send_smtp_email_sync error handling

未关闭
  • 哪里不对？
#2,250 1 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

@taneesha-reyyi 已经在做这个了。

开始于 2026年7月30日。

  • #2255 来自 @tmdeveloper007 —— 已关闭，未合并

评估

这个 Issue 还没有评估数据。

描述

Summary of What Needs to be Done:
Add unit tests for notification_service._send_smtp_email_sync in testing/backend/unit/test_smtp_notifications.py. This sync email helper has no direct unit tests despite handling critical notification delivery.

Changes that Need to be Made:
Add unit tests for _send_smtp_email_sync in testing/backend/unit/test_smtp_notifications.py (extend existing file):

For _send_smtp_email_sync(sender, recipients, subject, body, smtp_host, smtp_port):

  • raises ConnectionError when SMTP server is unreachable (mock socket.error)
  • raises TimeoutError when SMTP connection times out
  • successful send returns True with valid inputs
  • handles empty recipient list gracefully
  • handles missing subject or body (empty string is fine)
  • handles SMTP port as integer vs string

Impact that it would Provide:

  • Ensures critical notification path handles network failures gracefully
  • Improves reliability of email delivery for scan completion events
  • Pure function with no database dependencies

Note: This task is being handled by tmdeveloper007 — please assign to that account when picking it up.

主要语言
Python
星标
36
派生
234
30 天内没有已合并 PR

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

utksh1/SecuScan 的其他 Issue

查看 utksh1/SecuScan 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。