Announcement capture trusts a page global the page can define or replace
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 52/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- playwright, typescript
调研方向
Start by locating the announcement capture and checkPage adoption code, then read how the toast ancestor walk accesses attributes over CDP. Trace how the CLI init script exposes window.__usablDrain and how the path helper is guarded. Add tests for a page that predefines the drain and one that replaces it after load; each should produce a gap or failure, never a pass.
由索引模型根据 Issue 内容生成。
描述
What happens
Flow requirements read announcements through window.__usablDrain, a function in the page's own JavaScript world.
- On an adopted page (
checkPage), the capture is installed only if__usablDrainis not already defined. A page that defines its own before adoption keeps it. - On a CLI page, the init script defines it first, but page script can replace it afterwards.
Either way, page code can hand usabl announcements no screen reader spoke.
Why it matters
A flow requirement's expectedAnnouncement can pass on text the page supplied directly. That is a false green, and page text is supposed to be untrusted data.
Fix direction
Run the capture in an isolated world, the way the toast ancestor walk now reads attributes over CDP, or bind the drain to a value page script cannot reach. Add tests for a page that predefines the drain and for a page that replaces it after load. Both must give a gap or a failure, never a pass. The path helper has the same kind of guard and should be checked at the same time.
- 主要语言
- TypeScript
- 星标
- 0
- 派生
- 0
- 平均合并
- 2 小时 48 分钟
- 30 天内合并 PR
- 8
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
usabl-dev/usabl 的其他 Issue
-
area: engine bug
难度 2/5 1-3 小时 新手友好度 86/100
-
Stop hook allows a stop on an unknown verdict, and the self-check prints IDLE for a null verdict未关闭area: assistants bug
难度 2/5 1-3 小时 新手友好度 75/100
-
area: engine bug security
难度 2/5 1-3 小时 新手友好度 72/100
-
Overlay: browser context failures are counted per plugin, not per browser, and close is not shared未关闭area: overlay bug
难度 2/5 1-3 小时 新手友好度 64/100
-
area: engine enhancement performance
难度 2/5 1-3 小时 新手友好度 68/100
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
chaitin/MonkeyCode#1437 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 69/100
carbon-design-system/carbon-ai-chat#2615 ·
维护者通常 1 天内回复
-
e2e-failure ready-to-code
难度 2/5 1-3 小时 新手友好度 76/100
redhat-developer/rhdh-plugin-export-overlays#4486 · 1 条评论 ·
维护者通常 1 天内回复
-
[Bug]: fileUploadMatrix.test.ts URL case does a real DNS lookup and fails offline可能已有人在做 @r2jaff 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
ComposioHQ/composio#5054 ·
维护者通常 1 天内回复