[Bug]: robots.txt rules ending in `$` never match on Python 3.13 and older
维护者通常 1 天内回复
评估
调研方向
Start with patched_applies_to in crawl4ai/utils.py, where the robots.txt rule path is checked for a trailing $ or %24, and with the RobotsParser code that calls it. Run the reproduction script on Python 3.13 to confirm the four can_fetch results. Done means *.pdf$ blocks report.pdf, Allow: /$ allows the home page, and the tests cover both cases. The author says they are opening a PR for this, so check for one before starting.
由索引模型根据 Issue 内容生成。
描述
crawl4ai version
0.9.5 (also reproduced on develop at 1a6eddb)
Expected Behavior
A robots.txt rule that ends in $ only matches URLs that end at that point (RFC 9309, section 2.2.3). With check_robots_txt=True, Disallow: /*.pdf$ keeps the crawler away from /files/report.pdf, and Allow: /$ lets it fetch the home page.
Current Behavior
On Python 3.13 and older, rules ending in $ never match:
Disallow: /*.pdf$does not block/files/report.pdf, so the crawler fetches URLs the site disallows.- With
Allow: /$followed byDisallow: /, the home page is disallowed as well.
Below 3.14, urllib.robotparser.RuleLine quotes the rule path, so the $ is already %24 when patched_applies_to in crawl4ai/utils.py sees it. Its pattern.endswith('\\$') check never fires, and the regex looks for a literal %24. Rules without * (like Allow: /$) don't reach that code and are compared with startswith('/%24').
Python 3.14 supports $ natively and isn't affected. The description of #2278 mentions this gap ("Happy to do it separately"); I couldn't find an issue or PR for it.
Is this reproducible?
Yes
Inputs Causing the Bug
User-agent: *
Disallow: /*.pdf$
and
User-agent: *
Allow: /$
Disallow: /
Steps to Reproduce
Run the script below with Python 3.13. It serves the two robots.txt files from local HTTP servers, so no network is needed.
Code snippets
import asyncio
import tempfile
import threading
from http.server import BaseHTTPRequestHandler, HTTPServer
from crawl4ai.utils import RobotsParser
ROBOTS = {
8765: b"User-agent: *\nDisallow: /*.pdf$\n",
8766: b"User-agent: *\nAllow: /$\nDisallow: /\n",
}
class Handler(BaseHTTPRequestHandler):
def do_GET(self):
self.send_response(200)
self.send_header("Content-Type", "text/plain")
self.end_headers()
self.wfile.write(ROBOTS[self.server.server_port])
def log_message(self, *args):
pass
for port in ROBOTS:
server = HTTPServer(("127.0.0.1", port), Handler)
threading.Thread(target=server.serve_forever, daemon=True).start()
async def main():
parser = RobotsParser(cache_dir=tempfile.mkdtemp())
for url in [
"http://127.0.0.1:8765/files/report.pdf",
"http://127.0.0.1:8765/files/report.pdf.html",
"http://127.0.0.1:8766/",
"http://127.0.0.1:8766/page",
]:
print(url, "->", await parser.can_fetch(url, "bot"))
asyncio.run(main())
Output:
http://127.0.0.1:8765/files/report.pdf -> True
http://127.0.0.1:8765/files/report.pdf.html -> True
http://127.0.0.1:8766/ -> False
http://127.0.0.1:8766/page -> False
Expected:
http://127.0.0.1:8765/files/report.pdf -> False
http://127.0.0.1:8765/files/report.pdf.html -> True
http://127.0.0.1:8766/ -> True
http://127.0.0.1:8766/page -> False
OS
Windows 11
Python version
3.13.5 (3.11 and 3.12 quote the rule path the same way)
Browser
Not used (RobotsParser only fetches robots.txt with aiohttp)
Browser version
Error logs & Screenshots (if applicable)
No error; can_fetch() returns the wrong answer.
I'm opening a PR that treats a trailing %24 as the end anchor in patched_applies_to, with tests.
AI-assisted: found and reproduced with an AI coding agent; the example above was run locally.
- 主要语言
- Python
- 星标
- 87.2k
- 派生
- 9.1k
- 平均合并
- 1 天 6 小时
- 30 天内合并 PR
- 25
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
unclecode/crawl4ai 的其他 Issue
-
BUG: UserAgentGenerator.generate ignores browser_type and returns a random browser stack可能已有人在做 @HhH666-ux 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复
-
[Bug]: Hardened docker-compose (read_only) keeps full Chromium from starting: crashpad needs a writable ~/.config可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭🐞 Bug 📌 Root caused
难度 2/5 1-3 小时 新手友好度 70/100
unclecode/crawl4ai#2494 · 1 条评论 ·
维护者通常 1 天内回复
-
⚙ Done ✨ Enhancement
难度 2/5 1-3 小时 新手友好度 77/100
维护者通常 1 天内回复
-
⚙ Done 🐞 Bug 📌 Root caused
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
[Bug]: PDF images saved with save_images_locally=True come back with an empty src in result.media未关闭⚙ Done 🐞 Bug
难度 2/5 1-3 小时 新手友好度 78/100
unclecode/crawl4ai#2469 · 1 条评论 ·
维护者通常 1 天内回复
查看 unclecode/crawl4ai 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 85/100
521xueweihan/HelloGitHub#4385 ·
-
🐛 bug
难度 2/5 1-3 小时 新手友好度 72/100
pdm-project/pdm#4012 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 82/100
pollen-robotics/reachy_mini_conversation_app#611 ·
维护者通常 1 天内回复
-
难度 1/5 1-3 小时 新手友好度 91/100
aws-samples/sample-per-model-bedrock#913 ·
维护者通常 1 天内回复
-
lesson-submission pending-review
难度 1/5 1 小时以内 新手友好度 72/100
Ikalus1988/MisakaNet#5115 ·
维护者通常 1 天内回复