[Bug]: robots.txt rules ending in `$` never match on Python 3.13 and older

未关闭
#2,544 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@adityajai119 已经在做这个了。

开始于 2026年11月12日。

  • #2545 来自 @adityajai119 —— 未关闭

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
30/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
python
领域
backend

调研方向

Start with patched_applies_to in crawl4ai/utils.py, where the robots.txt rule path is checked for a trailing $ or %24, and with the RobotsParser code that calls it. Run the reproduction script on Python 3.13 to confirm the four can_fetch results. Done means *.pdf$ blocks report.pdf, Allow: /$ allows the home page, and the tests cover both cases. The author says they are opening a PR for this, so check for one before starting.

由索引模型根据 Issue 内容生成。

描述

crawl4ai version

0.9.5 (also reproduced on develop at 1a6eddb)

Expected Behavior

A robots.txt rule that ends in $ only matches URLs that end at that point (RFC 9309, section 2.2.3). With check_robots_txt=True, Disallow: /*.pdf$ keeps the crawler away from /files/report.pdf, and Allow: /$ lets it fetch the home page.

Current Behavior

On Python 3.13 and older, rules ending in $ never match:

  • Disallow: /*.pdf$ does not block /files/report.pdf, so the crawler fetches URLs the site disallows.
  • With Allow: /$ followed by Disallow: /, the home page is disallowed as well.

Below 3.14, urllib.robotparser.RuleLine quotes the rule path, so the $ is already %24 when patched_applies_to in crawl4ai/utils.py sees it. Its pattern.endswith('\\$') check never fires, and the regex looks for a literal %24. Rules without * (like Allow: /$) don't reach that code and are compared with startswith('/%24').

Python 3.14 supports $ natively and isn't affected. The description of #2278 mentions this gap ("Happy to do it separately"); I couldn't find an issue or PR for it.

Is this reproducible?

Yes

Inputs Causing the Bug
User-agent: *
Disallow: /*.pdf$

and

User-agent: *
Allow: /$
Disallow: /
Steps to Reproduce

Run the script below with Python 3.13. It serves the two robots.txt files from local HTTP servers, so no network is needed.

Code snippets
import asyncio
import tempfile
import threading
from http.server import BaseHTTPRequestHandler, HTTPServer

from crawl4ai.utils import RobotsParser

ROBOTS = {
    8765: b"User-agent: *\nDisallow: /*.pdf$\n",
    8766: b"User-agent: *\nAllow: /$\nDisallow: /\n",
}


class Handler(BaseHTTPRequestHandler):
    def do_GET(self):
        self.send_response(200)
        self.send_header("Content-Type", "text/plain")
        self.end_headers()
        self.wfile.write(ROBOTS[self.server.server_port])

    def log_message(self, *args):
        pass


for port in ROBOTS:
    server = HTTPServer(("127.0.0.1", port), Handler)
    threading.Thread(target=server.serve_forever, daemon=True).start()


async def main():
    parser = RobotsParser(cache_dir=tempfile.mkdtemp())
    for url in [
        "http://127.0.0.1:8765/files/report.pdf",
        "http://127.0.0.1:8765/files/report.pdf.html",
        "http://127.0.0.1:8766/",
        "http://127.0.0.1:8766/page",
    ]:
        print(url, "->", await parser.can_fetch(url, "bot"))


asyncio.run(main())

Output:

http://127.0.0.1:8765/files/report.pdf -> True
http://127.0.0.1:8765/files/report.pdf.html -> True
http://127.0.0.1:8766/ -> False
http://127.0.0.1:8766/page -> False

Expected:

http://127.0.0.1:8765/files/report.pdf -> False
http://127.0.0.1:8765/files/report.pdf.html -> True
http://127.0.0.1:8766/ -> True
http://127.0.0.1:8766/page -> False
OS

Windows 11

Python version

3.13.5 (3.11 and 3.12 quote the rule path the same way)

Browser

Not used (RobotsParser only fetches robots.txt with aiohttp)

Browser version
Error logs & Screenshots (if applicable)

No error; can_fetch() returns the wrong answer.

I'm opening a PR that treats a trailing %24 as the end anchor in patched_applies_to, with tests.

AI-assisted: found and reproduced with an AI coding agent; the example above was run locally.

主要语言
Python
星标
87.2k
派生
9.1k
平均合并
1 天 6 小时
30 天内合并 PR
25

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

unclecode/crawl4ai 的其他 Issue

查看 unclecode/crawl4ai 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。