Explicit runIds bulk cancel silently excludes runs older than seven days

未关闭
#5,110 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

  • #5111 来自 @granbellllc-png —— 已关闭,未合并
  • #5112 来自 @almagas —— 已关闭,未合并

评估

难度
3/5
预计耗时
1-2 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
领域
api, backend

调研方向

Start with convertRunListInputOptionsToFilterRunsOptions in apps/webapp/app/services/runsRepository/runsRepository.server.ts and its call to timeFilters; compare it with freezeRunListFilters in apps/webapp/app/v3/services/bulk/BulkActionV2.server.ts. Add regression coverage for count and paginated selection of explicit IDs at T−30 days and T−1 day, while confirming filter-only calls keep the seven-day default. Two linked pull requests are already closed, so check their changes and discussion before taking this on.

由索引模型根据 Issue 内容生成。

描述

SDK 4.8.3, Trigger.dev Cloud. Observed during a real cancellation; hosted backend revision unknown.

Reproduce

  1. Select two cancellable runs in one environment: one created within seven days, one still DELAYED and older than seven days.
  2. Call runs.bulk.cancel({ runIds: [recentRunId, oldDelayedRunId] }) and poll to completion.
  3. Retrieve the older run directly.

Expected: both explicit IDs are selected. The documentation says the seven-day default applies only to filter selections.

Actual: only recent IDs contribute to counts.total/success; failure is zero. The omitted older run remains DELAYED and directly retrievable. No time filter was supplied. We stopped on the count mismatch.

Matching public source: at bdcbc61ab2871f7cc81f29ec36e42c8676ff6aa9, freezeRunListFilters leaves explicit IDs unbounded. However, convertRunListInputOptionsToFilterRunsOptions calls timeFilters without dates, reintroducing its 7d default for both count and batch selection. This source behavior matches the Cloud observation; its deployed revision is not established.

Suggested regression: count and paginated selection include explicit IDs at T−30 days and T−1 day; filter-only calls without a range retain the seven-day default.

主要语言
TypeScript
星标
16.5k
派生
1.5k
平均合并
1 天 15 小时
30 天内合并 PR
17

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

triggerdotdev/trigger.dev 的其他 Issue

查看 triggerdotdev/trigger.dev 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。