bug: a resumed run whose restore fails is requeued behind newer runs
维护者通常 1 天内回复
还没有人认领这个 Issue。
- #5114 来自 @granbellllc-png —— 已关闭,未合并
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- node.js, typescript
调研方向
Start with internal-packages/run-engine/src/run-queue/index.ts and trace #callNackMessage alongside tryNackAndRequeue, which handles checkpointed runs. Read the reproduction instructions and tests in the linked repro/resumed-run-queue-position branch, then compare the suggested fix with the direct nack paths in dequeueSystem.ts and engine/index.ts. Done means a regression test shows a failed restore keeps its queue position ahead of newer runs while repeated failures still back off.
由索引模型根据 Issue 内容生成。
描述
Provide environment information
System:
OS: Linux 6.8 Ubuntu 24.04.5 LTS 24.04.5 LTS (Noble Numbat)
CPU: (16) x64 AMD Ryzen 7 7700 8-Core Processor
Memory: 48.87 GB / 61.89 GB
Container: Yes
Shell: 5.2.21 - /bin/bash
Binaries:
Node: 24.22.1 - /usr/local/bin/node
Yarn: 1.22.22 - /usr/local/bin/yarn
npm: 11.19.1 - /usr/local/bin/npm
pnpm: 12.15.0 - /usr/local/bin/pnpm
The runs were on Trigger.dev Cloud: prod environment, us-east-1. Tasks were deployed with the trigger.dev CLI and @trigger.dev/sdk 4.5.14, runtime: "node-24". The output above is from the machine we reproduced on.
Describe the bug
A run that resumes after a wait is enqueued at its original queue position. continueRunIfUnblocked says so: "Re-enqueue with the original timestamp, so waiting runs dequeue before new runs." If the restore then fails before the run continues, the run is requeued through tryNackAndRequeue with no retry time. RunQueue then scores the message at now + backoff (internal-packages/run-engine/src/run-queue/index.ts, #callNackMessage). The run loses its position and waits behind every run that was triggered after it.
What we saw on 2026-11-06:
- Two parent runs called
batchTriggerAndWaitwith about 50 children each, and were checkpointed while they waited. Their queue hasconcurrencyLimit: 4and held a backlog of about 100 queued runs. - All children ended by 21:03 and 21:59 UTC. A few children were OOM-killed, and each of those was marked
CRASHED(TASK_PROCESS_OOM_KILLED) 300 s after it started. - Each parent was then requeued once, at 22:21 and 22:04 UTC. After that the API showed
status: "QUEUED",attempts: [], and a trace that ends atbatchTriggerAndWait(). In the dashboard the run looks as if it never started. - The parents stayed queued for over 70 minutes while runs created after them kept starting in the same queue. We cancelled them at 23:32 UTC. That was about 4.5 minutes before the last run that was queued ahead of them started, so we think they were waiting their turn, not lost.
- Each requeue freed a queue slot that another run took within 0.2 s. As far as we can tell from the code, only
tryNackAndRequeuewritesPENDINGfor a run that is resuming from a checkpoint.
Expected: a resume whose restore has to be retried keeps its place ahead of runs triggered after it, as the first resume does.
We can't see why the restores failed. The parents ran on a small machine and were close to its memory limit when they started waiting, so we think the restored process was OOM-killed. That part is our sizing. See "Additional information" for how such a restore is reported.
Reproduction repo
https://github.com/PlunderStruck/trigger.dev/tree/repro/resumed-run-queue-position
To reproduce
The branch adds one run-engine test file, explained in repro/resumed-run-queue-position/README.md. It uses containerTest and a real RunEngine. The tests assert today's behaviour, so they pass on main:
cd internal-packages/run-engine
pnpm run test ./src/engine/tests/resumedRunQueuePositionRepro.test.ts --run
Each test:
- Triggers a parent in a queue with concurrency limit 1, starts it, and blocks it on a waitpoint.
- Checkpoints it, then completes the waitpoint, so the parent is enqueued for a restore and dequeued ahead of newer runs, as designed.
- Triggers a newer run while the restore holds the slot.
- Fails the restore before
continueRunExecution, in one of two ways:- Stall. The restored runner never continues, so the
PENDING_EXECUTINGheartbeat requeues it. - Supervisor report. The supervisor reports the restore as
requeue, asclassifyRestoreFailuredoes for a Runner that failed with reasonOOMKilled.
- Stall. The restored runner never continues, so the
- Asserts that the parent is
PENDINGwith its checkpoint, that the next dequeue returns the newer run, and that the parent is dequeued only after the newer run finishes.
Suggested fix
These are ideas from reading the code; you know the trade-offs far better than we do.
- Keep the position on the first requeue of a resume.
tryNackAndRequeuealready knows whether the run has a checkpoint. It could asknackMessageto redeliver at the message's original score, as the resume enqueue does. Later requeues would keep the backoff, so a restore that keeps failing does not spend the 12 queue attempts in a tight loop. Cold starts would be unchanged. We put this on a branch with a regression test inrestoreOutcome.test.ts, which fails without the change: https://github.com/triggerdotdev/trigger.dev/compare/main...PlunderStruck:trigger.dev:fix/resumed-run-queue-position. It adds 18 lines torunAttemptSystem.tsandrun-queue/index.ts, most of them comments. We'd be glad to open it as a PR if that's welcome. - Not covered by that branch: the direct
runQueue.nackMessagecalls indequeueSystem.tsandengine/index.ts(error and admin paths) still requeue a resume atnow + backoff.
Additional information
- An OOM-killed restore is retried on the same machine with no reason recorded.
classifyRestoreFailure(apps/supervisor/src/workloadManager/runCrd.ts) mapsOOMKilledto its default{ outcome: "requeue" }. The runner-kill reporter also skips a run whose snapshot is notEXECUTING. The run therefore records no attempt and no error,retry.outOfMemorycan't move it to a larger machine, and each retry goes to the back of the queue until the 12 queue attempts are spent. MappingOOMKilledto a failure withTASK_PROCESS_OOM_KILLEDwould letretry.outOfMemoryapply. We haven't changed this, because we can't confirm the restore reason on Cloud. - No trace or attempt event for a requeue.
tryNackAndRequeueemits no run event. A run that has resumed and been requeued looks the same as one that has never started. - Related but different: #4971 and #4988 (the parent was never resumed) and #5060 (the run stayed
EXECUTINGafter its task finished). Here the parent is resumed but then requeued behind newer runs. - We can share the run IDs privately.
- 主要语言
- TypeScript
- 星标
- 16.5k
- 派生
- 1.5k
- 平均合并
- 1 天 15 小时
- 30 天内合并 PR
- 17
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
triggerdotdev/trigger.dev 的其他 Issue
-
bug: retry.fetch ignores the caller's abort signal and retries aborted requests可能重新可做 关联的 PR 已关闭且未合并。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
triggerdotdev/trigger.dev#5116 · 2 条评论 ·
维护者通常 1 天内回复
-
bug: Chat transport crashes on Safari < 17.4: AbortSignal.any is not a function可能重新可做 关联的 PR 已关闭且未合并。 未关闭
难度 2/5 1-3 小时 新手友好度 83/100
triggerdotdev/trigger.dev#5098 · 2 条评论 ·
维护者通常 1 天内回复
-
bug: Side menu items lose their active state on detail pages可能重新可做 关联的 PR 已关闭且未合并。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
triggerdotdev/trigger.dev#5088 ·
维护者通常 1 天内回复
-
bug: RBAC loader logs "plugin found but failed to load" when @triggerdotdev/plugins is simply not installed可能重新可做 @itsfaryal 于 17 天前认领,目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
triggerdotdev/trigger.dev#5083 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 83/100
triggerdotdev/trigger.dev#5072 · 1 条评论 ·
维护者通常 1 天内回复
查看 triggerdotdev/trigger.dev 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
bug platform-android
难度 2/5 1-3 小时 新手友好度 68/100
Termix-SSH/Mobile#146 · 1 条评论 ·
维护者通常 2 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 66/100
devswha/herdr-web-ui#3875 ·
-
难度 1/5 1 小时以内 新手友好度 88/100
-
area: runtime chore cli consistency dependencies developer-experience difficulty: easy discovery documentation enhancement good first issue help wanted hygiene json-output packaging priority: P3 tests version
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复