runs.subscribeToRun().withStreams() aborts active stream pipes as soon as the run status stream closes

未关闭
#5,076 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
67/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃

调研方向

Start at the implementation of runs.subscribeToRun().withStreams() and trace how completion of the run status stream aborts the shared signal and child stream subscriptions. Reproduce with a task that emits several realtime chunks before returning, then check that buffered chunks are yielded after the terminal run update. Done when stream completion drains queued chunks and caller cancellation still aborts subscriptions.

由索引模型根据 Issue 内容生成。

描述

What version of Trigger.dev are you using?

main (commit dd5eec1)

What Node.js version are you using?

20.18.0

What operating system are you using?

Linux

What build tool are you using?

tsup

Describe the Bug

When consuming runs.subscribeToRun(runId).withStreams(), the subscription aborts its shared abort signal as soon as the upstream run status stream finishes. If a task emits realtime stream chunks right before completing, the outer stream and its child stream subscriptions get aborted before buffered or in-flight stream events finish draining, so trailing stream chunks are dropped.

Reproduction Steps
  1. Trigger a task that writes several chunks to a realtime stream and immediately returns.
  2. Subscribe to the run using for await (const part of runs.subscribeToRun(runId).withStreams()).
  3. Observe that once the terminal run snapshot is read from the upstream run stream, the shared abort signal fires right away and cancels the outer stream reader and active realtime stream pipes before all queued stream chunks are yielded.
Expected Behavior

withStreams() should allow buffered run updates and active child stream subscriptions to finish draining naturally when the run completes, and only abort everything when the caller explicitly unsubscribes or cancels the outer stream.

Additional Context

Happy to open a PR with a test for this if you would like to vouch it!

主要语言
TypeScript
星标
16.5k
派生
1.5k
平均合并
1 天 15 小时
30 天内合并 PR
17

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

triggerdotdev/trigger.dev 的其他 Issue

查看 triggerdotdev/trigger.dev 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。