[Bug]: Clip pages trust X-Forwarded-Host/Proto from any client

未关闭
#106 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
半天
新手友好度
68/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
rust
领域
backend, security

调研方向

Start at origin() in src/api/clips.rs around line 1620 and see how the built URL feeds og:url, og:image and the <video src>. Then read state.public_url() and the throttle's network.trusted-proxies / network.trusts_proxy check to reuse that trust decision instead of inventing one. Done means a request with X-Forwarded-Host: evil.example yields public-url (or Host) in the page, with a test covering the untrusted and trusted-proxy cases.

由索引模型根据 Issue 内容生成。

描述

bug

[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.

Version

0.40.0 (feat/desktop, 017a837b)

Area

Clips

What happened?

origin() in the clip page builds URLs from X-Forwarded-Proto and X-Forwarded-Host sent by anyone (src/api/clips.rs:1620). It ignores [network] trusted-proxies, which the throttle respects, and the configured public-url. Those URLs go into the page's og:url, og:image and <video src>.

Steps to reproduce

Request /c/<code> with X-Forwarded-Host: evil.example: the page's video and meta tags point at evil.example.

Expected behavior

Clip pages use public-url when set, and only take forwarded headers from trusted proxies otherwise.

Suggested fix

Use state.public_url() first; fall back to forwarded headers only when the peer passes network.trusts_proxy, then to Host.

主要语言
TypeScript
星标
4
派生
1
平均合并
4 小时 49 分钟
30 天内合并 PR
5

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

tinystream-dev/tinystream 的其他 Issue

查看 tinystream-dev/tinystream 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。