Bug: HttpWaitStrategy ignores response predicates for accepted HTTP error statuses

未关闭 适合新手
#1,143 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@PranavMulakala 已经在做这个了。

开始于 2026年10月23日。

  • #1144 来自 @PranavMulakala —— 未关闭

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
85/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
python
领域
testing

调研方向

从 testcontainers/core/wait_strategies.py 的 HttpWaitStrategy._handle_http_error() 开始,它在未检查 _response_predicate 的情况下直接返回 True。阅读 _check_response() 以了解正常的谓词求值方式。运行该 issue 的复现脚本以看到错误的 ready,然后修改错误分支使其对谓词求值。完成意味着脚本抛出 TimeoutError。

由索引模型根据 Issue 内容生成。

描述

Describe the bug

HttpWaitStrategy.for_response_predicate() is not evaluated when an HTTP endpoint returns an explicitly accepted error status, such as 404 or 503. The strategy reports ready even when the response body does not match the predicate.

This affects both for_status_code(...) and for_status_code_matching(...). HTTP 200 responses do evaluate the body predicate. A caller that deliberately accepts an error status still needs the additional body condition to pass; accepting the status should not bypass that condition.

Found while testing HTTP readiness behavior on main at 6146aa1170f415fcc825ed9bddc4eacbeb937a12 (package version 4.15.0). I searched issues and PRs for HttpWaitStrategy, for_response_predicate, response predicate, and HTTPError and did not find this behavior reported. The HTTPError resource-cleanup work in #1115 is related code but a different problem.

Reproduction

This endpoint always returns 503 with body starting. The status is deliberately accepted, but the body predicate requires ready.

"""Reproduce a false-positive HTTP readiness result (requires Docker)."""
from testcontainers.core.container import DockerContainer
from testcontainers.core.wait_strategies import HttpWaitStrategy

server = """
from http.server import BaseHTTPRequestHandler, HTTPServer

class Handler(BaseHTTPRequestHandler):
    def do_GET(self):
        self.send_response(503)
        self.end_headers()
        self.wfile.write(b"starting")

HTTPServer(("0.0.0.0", 8080), Handler).serve_forever()
"""
strategy = (
    HttpWaitStrategy(8080)
    .for_status_code(503)
    .for_response_predicate(lambda body: body == "ready")
    .with_startup_timeout(2)
    .with_poll_interval(0.1)
)
try:
    with (
        DockerContainer("python:3.12-alpine")
        .with_exposed_ports(8080)
        .with_command(["python", "-u", "-c", server])
        .waiting_for(strategy)
    ):
        raise AssertionError("BUG: marked ready even though the body is always 'starting'")
except TimeoutError:
    print("Correct: the body never matched, so readiness timed out.")

Expected behavior

The wait should continue polling and raise TimeoutError because the body never matches.

Actual behavior

The context manager enters immediately after the first HTTP response; the assertion fails. In a second reproduction, an endpoint returning starting on request 1 and ready on request 2 receives only one request before the wait finishes.

Root cause and proposed fix

urlopen() raises HTTPError for error statuses. _handle_http_error() accepts the status and returns True without evaluating _response_predicate. The normal response path in _check_response() does evaluate it.

Evaluate the body predicate for accepted HTTP errors while the existing with e: block still owns the response. This preserves status-only waits and response cleanup.

Runtime environment

  • macOS / Apple silicon; Colima Docker runtime
  • Regression tests reproduced on Python 3.12.14
  • Patch validated on Python 3.10.22, 3.12.14, 3.13.17, and 3.14.9
  • Real HTTP server in python:3.12-alpine
主要语言
Python
星标
2.3k
派生
395
PR 合并指标
30 天内没有已合并 PR

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

testcontainers/testcontainers-python 的其他 Issue

查看 testcontainers/testcontainers-python 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。