Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

Add lifecycle hooks that do not need a subclass

未关闭
  • 哪里不对？
#1,554 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
docker, node.js, typescript
领域
backend, testing

调研方向

Start with the three files named under “Where,” then read #1520, #1521, and #1582 to understand the dependencies on builder state, reuse behavior, and startup time. Implement registered lifecycle hooks and the startup command shorthand while retaining the protected methods. Done means hooks receive the described context and can be combined; verify behavior for each lifecycle stage and reused containers.

由索引模型根据 Issue 内容生成。

描述

enhancement minor

What happens

The lifecycle hooks are protected methods: beforeContainerCreated, containerCreated, containerStarting and containerStarted on GenericContainer, and containerStopping and containerStopped on AbstractStartedContainer. Using one means writing a subclass.

  • A hook cannot be added to a module container without subclassing the module.
  • Two independent behaviours cannot be combined, because each wants to be the subclass.
  • A one-off "run this command once the container is ready" needs a class.

Expected

Hooks can be registered on the builder, and several can be registered:

new PostgreSqlContainer(image).withLifecycleHooks({
  started: async (container) => {
    await container.exec(["psql", "-f", "/seed.sql"]);
  },
});

plus a shorthand for the commonest case, withStartupCommands([...]). The protected methods keep working.

Where

  • packages/testcontainers/src/generic-container/generic-container.ts
  • packages/testcontainers/src/generic-container/started-generic-container.ts
  • packages/testcontainers/src/test-container.ts

Notes

  • Go has WithLifecycleHooks and WithAdditionalLifecycleHooks, with hooks for each of pre/post create, start, ready, stop and terminate, and the shorthands WithStartupCommand and WithAfterReadyCommand.
  • Each hook should be told whether the container was reused.
  • Pass hooks one context object instead of more positional arguments. It should carry reused, the remaining startup time and, later, an abort signal.

Dependencies

  • Stack on #1520: registered hooks are builder state, and they run inside the reworked start().
  • Coordinate with #1521: that issue decides when hooks run for a reused container.
  • Coordinate with #1582: the hook context carries the remaining startup time.
主要语言
TypeScript
星标
2.6k
派生
274
平均合并
1 天 14 小时
30 天内合并 PR
44

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 提供 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

testcontainers/testcontainers-node 的其他 Issue

查看 testcontainers/testcontainers-node 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。