Make stopped containers restartable, or drop the empty stopped types
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 56/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- docker, node.js, typescript
调研方向
Start with the listed stopped container and Docker Compose environment files, then trace how stop() and down() construct and return these objects. Compare those paths with the expected restart and removal behavior, including wait strategy handling. Done means the stopped states support the requested lifecycle operations or the empty marker types are removed or documented, with tests covering the chosen behavior.
由索引模型根据 Issue 内容生成。
描述
What happens
stop(), down() and Network.stop() return a "stopped" object, but those objects do very little:
| Type | Members |
|---|---|
StoppedTestContainer |
getId(), copyArchiveFromContainer() |
StoppedNetwork |
none |
StoppedDockerComposeEnvironment |
down() |
DownedDockerComposeEnvironment |
none |
After container.stop({ remove: false }) the container still exists, but the returned object cannot start it again or remove it. Doing either means dropping to getContainerRuntimeClient() and Dockerode. The same goes for a Compose environment after stop(): it can be taken down but not brought back up.
Expected
Either the stopped states become useful, or the empty ones go away:
StoppedTestContainergainsstart()(returning a started container, with wait strategy applied) andremove().StoppedDockerComposeEnvironmentgains a way to start again.StoppedNetworkandDownedDockerComposeEnvironmentare replaced byPromise<void>, or documented as markers.
Where
packages/testcontainers/src/test-container.tspackages/testcontainers/src/generic-container/stopped-generic-container.tspackages/testcontainers/src/network/network.tspackages/testcontainers/src/docker-compose-environment/stopped-docker-compose-environment.tspackages/testcontainers/src/docker-compose-environment/downed-docker-compose-environment.ts
Notes
- Go's container has
Start,StopandTerminateon one type, so a stopped container can be started again. - Adding methods is
minor. Removing the empty classes would bemajor.
Dependencies
- Nothing blocks this. It can start now.
- 主要语言
- TypeScript
- 星标
- 2.6k
- 派生
- 274
- 平均合并
- 1 天 14 小时
- 30 天内合并 PR
- 44
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
testcontainers/testcontainers-node 的其他 Issue
-
enhancement minor
难度 2/5 1-3 小时 新手友好度 74/100
testcontainers/testcontainers-node#1539 ·
维护者通常 1 天内回复
-
enhancement minor
难度 2/5 1-3 小时 新手友好度 82/100
testcontainers/testcontainers-node#1533 ·
维护者通常 1 天内回复
-
enhancement minor
难度 2/5 1-3 小时 新手友好度 77/100
testcontainers/testcontainers-node#1531 ·
维护者通常 1 天内回复
-
enhancement minor
难度 2/5 1-3 小时 新手友好度 76/100
testcontainers/testcontainers-node#1529 ·
维护者通常 1 天内回复
-
enhancement minor
难度 2/5 1-3 小时 新手友好度 78/100
testcontainers/testcontainers-node#1528 ·
维护者通常 1 天内回复
查看 testcontainers/testcontainers-node 的全部 Issue
相似的 Issue
-
documentation good first issue hacktoberfest help wanted
难度 2/5 1-3 小时 新手友好度 78/100
libredb/libredb-studio#1756 ·
维护者通常 1 天内回复
-
state:triage-needed
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
难度 1/5 1 小时以内 新手友好度 72/100
lingdojo/kana-dojo#32365 · 1 条评论 · 5 个 reaction ·
维护者通常 1 天内回复
-
friction
难度 2/5 1-3 小时 新手友好度 72/100
kentcdodds/kody#3706 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
copperheadhq/copperhead#378 ·
维护者通常 1 天内回复