Address Compose containers by service name
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- docker-compose, typescript
- 领域
- devtools, testing-qa
调研方向
Start by reading packages/testcontainers/src/docker-compose-environment/docker-compose-environment.ts and started-docker-compose-environment.ts, then trace the compose name parsing entry point in packages/testcontainers/src/docker-runtime/clients/compose/parse-compose-container-name.ts. Check how containers are identified and how wait strategies and getContainer resolve them; done means those APIs accept service names with an optional replica index while retaining container-name support, and the constructor parameter is named for the directory it receives.
由索引模型根据 Issue 内容生成。
描述
What happens
DockerComposeEnvironment identifies containers by container name, not by the service name written in the compose file:
const environment = await new DockerComposeEnvironment(dir, "docker-compose.yml")
.withWaitStrategy("redis-1", Wait.forLogMessage("Ready to accept connections"))
.up();
const redis = environment.getContainer("redis-1");
- The
-1suffix is a Compose naming detail the user has to know. - A service with
container_name:set is keyed by that name instead. - A wait strategy registered under the service name (
"redis") matches nothing.up()now logs a warning for that case, and the docs carry a callout, but the default wait strategy is still what runs. getContainer("redis")throwsCannot get container "redis" as it is not running.
The first constructor parameter is also misnamed: composeFilePath is the directory that contains the compose files, and the docs assign it "/path/to/build-context".
Expected
withWaitStrategyandgetContaineraccept a service name, with an optional replica index, and keep accepting a container name.- The constructor parameter is named for what it is.
Where
packages/testcontainers/src/docker-compose-environment/docker-compose-environment.tspackages/testcontainers/src/docker-compose-environment/started-docker-compose-environment.tspackages/testcontainers/src/container-runtime/clients/compose/parse-compose-container-name.ts
Notes
- Java uses service names throughout:
waitingFor(serviceName, strategy),getServiceHost(serviceName, port),getContainerByServiceName(serviceName), with an optional instance number onwithExposedService. Go hasServiceContainer(ctx, svcName)andWaitForService(name, strategy). - Compose labels each container with
com.docker.compose.serviceandcom.docker.compose.container-number, so resolving a service does not need name parsing. - Related: #647.
Dependencies
- Nothing blocks this. It can start now.
- 主要语言
- TypeScript
- 星标
- 2.6k
- 派生
- 274
- 平均合并
- 1 天 14 小时
- 30 天内合并 PR
- 44
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
testcontainers/testcontainers-node 的其他 Issue
-
enhancement minor
难度 2/5 1-3 小时 新手友好度 74/100
testcontainers/testcontainers-node#1539 ·
维护者通常 1 天内回复
-
enhancement minor
难度 2/5 1-3 小时 新手友好度 82/100
testcontainers/testcontainers-node#1533 ·
维护者通常 1 天内回复
-
enhancement minor
难度 2/5 1-3 小时 新手友好度 77/100
testcontainers/testcontainers-node#1531 ·
维护者通常 1 天内回复
-
enhancement minor
难度 2/5 1-3 小时 新手友好度 76/100
testcontainers/testcontainers-node#1529 ·
维护者通常 1 天内回复
-
enhancement minor
难度 2/5 1-3 小时 新手友好度 78/100
testcontainers/testcontainers-node#1528 ·
维护者通常 1 天内回复
查看 testcontainers/testcontainers-node 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
dsh-market/dsh-market#877 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
stellar/stellar-dev-skill#151 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
area:arcade game ready-for-agent
难度 2/5 1-3 小时 新手友好度 62/100
fderuiter/deruiter.dev#2281 · 1 条评论 ·
维护者通常 1 天内回复
-
scope: data grid type: bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 2 天内回复