Failed container starts aren't always reported

未关闭
#69 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
c, docker, postgresql
领域
devops, testing-qa

调研方向

Start with tc_container_run() and the generic-container-test changes described in the issue, then inspect the PostgreSQL container demo. Trace how immediate container termination and the error value are handled, including whether container logs are collected. Done means failed starts reliably fail the demo and expose useful diagnostics instead of reporting a passing test.

由索引模型根据 Issue 内容生成。

描述

I discovered this while working on a 'postgresql container demo' - and before discovering the outstanding PR related to PostgreSQL. That PR may have fixed this specific issue but I'm sure similar issues abound and that possibility should be documented.

TLDR

  • fix tc_container_run() so the error value is actually used
  • in demos add check that the application hasn't already exited
  • in demos add container logs in addition to docker daemon logs
  • remind, remind, remind everyone that it's critical to verify results. Things will slip through for a long time.

Details

The problem is that the official PostgreSQL images require a password to be provided via an environment variable. Any attempt to run one of these images without one immediately fails.

Sample output:

bgiles@eris:$ docker run postgres:18
Error: Database is uninitialized and superuser password is not specified.
       You must specify POSTGRES_PASSWORD to a non-empty value for the
       superuser. For example, "-e POSTGRES_PASSWORD=password" on "docker run".

       You may also use "POSTGRES_HOST_AUTH_METHOD=trust" to allow all
       connections without a password. This is *not* recommended.

       See PostgreSQL documentation about "trust":
       https://www.postgresql.org/docs/current/auth-trust.html

However when I made a quick tweak to generic-container-test to replace the image name and remove the wait I see no indication of a problem. Nothing in the logs, the test is reported as passing.

  41   │ 
  42   │ 2/5 Testing: postgresql_container_demo
  43   │ 2/5 Test: postgresql_container_demo
  44   │ Command: "/home/bgiles/code/testcontainers-native/build/demo/postgresql-container/postgresql-container-demo.out"
  45   │ Directory: /home/bgiles/code/testcontainers-native/build/demo/postgresql-container
  46   │ "postgresql_container_demo" start time: Feb 02 12:51 MST
  47   │ Output:
  48   │ ----------------------------------------------------------
  49   │ Creating new container: postgres:18-alpine
  50   │ RequestID: 0
  51   │ Testcontainers properties file has been found: /home/bgiles/.testcontainers.properties
  52   │ 2026/02/02 12:51:20 github.com/testcontainers/testcontainers-go - Connected to docker: 
  53   │   Server Version: 29.2.0
  54   │   API Version: 1.43
  55   │   Operating System: Ubuntu 24.04.3 LTS
  56   │   Total Memory: 64221 MB
  57   │ 2026/02/02 12:51:20 🐳 Creating container for image docker.io/testcontainers/ryuk:0.5.1
  58   │ 2026/02/02 12:51:20 ✅ Container created: cbf1b3aefe60
  59   │ 2026/02/02 12:51:20 🐳 Starting container: cbf1b3aefe60
  60   │ 2026/02/02 12:51:20 ✅ Container started: cbf1b3aefe60
  61   │ 2026/02/02 12:51:20 🚧 Waiting for container id cbf1b3aefe60 image: docker.io/testcontainers/ryuk:0.5.1. Waiting for: &{Port:8080/tcp timeout:<nil> PollInterval:100ms}
  62   │ 2026/02/02 12:51:20 🐳 Creating container for image postgres:18-alpine
  63   │ 2026/02/02 12:51:20 ✅ Container created: 84c6797e69bb
  64   │ 2026/02/02 12:51:20 🐳 Starting container: 84c6797e69bb
  65   │ 2026/02/02 12:51:20 ✅ Container started: 84c6797e69bb
  66   │ ContainerId: 0: 
  67   │ 2026/02/02 12:51:20 🐳 Terminating container: 84c6797e69bb
  68   │ 2026/02/02 12:51:21 🚫 Container terminated: 84c6797e69bb
  69   │ Terminating container: 0
  70   │ <end of output>
  71   │ Test time =   0.91 sec
  72   │ ----------------------------------------------------------
  73   │ Test Passed.
  74   │ "postgresql_container_demo" end time: Feb 02 12:51 MST
  75   │ "postgresql_container_demo" time elapsed: 00:00:00
  76   │ ----------------------------------------------------------

(I added a few extra print statements and fflush() so I can see those print statements at the right point.)

This may be something as simple as fixing

    char* error = "";
    int containerId = tc_container_run(requestId, error);
    if (containerId == -1) {
        printf("Failed to run the container: %s\n", error);
        return -1;
    }

since C doesn't have pass-by-reference. and 'error' will never change. The Go library may not even consider the immediate termination of the application an error.

However we should have the ability to determine if the application has already terminated before we wait for the server to start.

主要语言
C
星标
58
派生
14
PR 合并指标
30 天内没有已合并 PR

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

testcontainers/testcontainers-native 的其他 Issue

查看 testcontainers/testcontainers-native 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。