binary-search/Solution.java: prints -1 when the target is the last element (`9 1 3 5 7 9`) or in a 1-element list (`5 5`)
维护者通常 1 天内回复
评估
调研方向
The bug is in problems/binary-search/Solution.java, where the search reports -1 once it narrows to a single position. Check linked pull request #30 first, since work is already under way. Done means 9 1 3 5 7 9 prints 4, 5 5 prints 0, and 3 1 3 prints 1, with those cases added to cases.txt and python3 run.py binary-search passing.
由索引模型根据 Issue 内容生成。
描述
What I did
- Fresh checkout of
main, JDK 17. - Compile the Java solution and run it on a few inputs (the input is one line: the target, then the sorted list):
cd problems/binary-search
javac Solution.java
echo "9 1 3 5 7 9" | java Solution
echo "5 5" | java Solution
echo "3 1 3" | java Solution
echo "3 1 3 5" | java Solution
- For comparison, the Python solution:
echo "9 1 3 5 7 9" | python3 solution.py
What I expected
The problem README says: "Print the position (starting from 0) of the target in the list, or -1 if it isn't there." (problems/binary-search/README.md)
So 9 1 3 5 7 9 should print 4, 5 5 should print 0, 3 1 3 should print 1, and 3 1 3 5 should print 1.
What happened instead
9 1 3 5 7 9 -> -1 (expected 4)
5 5 -> -1 (expected 0)
3 1 3 -> -1 (expected 1)
3 1 3 5 -> 1 (correct)
The target is found, then reported as missing, whenever the search narrows to a single position. The Python and C++ solutions print the right answer for all of these. python3 run.py binary-search passes today because none of the cases in cases.txt ends the search on a single remaining position.
Environment
code-corner main @ 0c95800, JDK 17, Windows 11.
I'd like to work on the fix for this, and add the failing inputs to cases.txt as the Contributing section asks.
- 主要语言
- Python
- 星标
- 1
- 派生
- 6
- 平均合并
- 17 小时 52 分钟
- 30 天内合并 PR
- 14
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
techcsispit/code-corner 的其他 Issue
-
prime/solution.java doesn't compile: public class PrimeCheck in solution.java, README requires Solution.java with a Solution class可能已有人在做 @tanujb03 于 2 天前认领。 未关闭
难度 1/5 1 小时以内 新手友好度 82/100
techcsispit/code-corner#35 ·
维护者通常 1 天内回复
-
Prime solution in C++ incorrectly returns true for some composite numbers可能已有人在做 @paramsj 于 1 天前认领。 未关闭
难度 1/5 1 小时以内 新手友好度 25/100
techcsispit/code-corner#38 ·
维护者通常 1 天内回复
-
Failed compilations always report 0.000 seconds可能已有人在做 @Shivangi-singh18 于 1 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 35/100
techcsispit/code-corner#37 · 1 条评论 ·
维护者通常 1 天内回复
-
run.py: Python solutions are skipped on Windows when run via python instead of python3可能已有人在做 @tanujb03 于 2 天前认领。 未关闭bug good first issue
难度 1/5 1 小时以内 新手友好度 15/100
techcsispit/code-corner#29 ·
维护者通常 1 天内回复
-
fibonacci/solution.c: prints negative numbers for n of 47 or more (F(90) prints -1581614984)可能已有人在做 @tanujb03 于 2 天前认领。 未关闭bug good first issue
难度 2/5 1-3 小时 新手友好度 25/100
techcsispit/code-corner#27 ·
维护者通常 1 天内回复
查看 techcsispit/code-corner 的全部 Issue
相似的 Issue
-
难度 1/5 1-3 小时 新手友好度 87/100
adri0/scadustats#128 ·
维护者通常 1 天内回复
-
`TIMESTAMP`, `TIMESTAMP_NTZ`, `TINYINT` and the other `TypeDecorator`s don't declare `python_type`未关闭
难度 2/5 1-3 小时 新手友好度 78/100
-
RPBC未关闭awaiting policy acceptance precheck-passed
难度 1/5 1 小时以内 新手友好度 78/100
Bioconductor/BiocContributions#240 · 1 条评论 ·
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
documentation good first issue launch
难度 2/5 1-3 小时 新手友好度 83/100
FlologixAI/etchwork#4 ·