fifottl/limfifottl: stop() blocks forever while RW, drop() leaks the TTL fiber
还没有人认领这个 Issue。
评估
调研方向
Start in queue/abstract/driver/fifottl.lua, especially the TTL loop and stop-channel setup referenced at lines 171-177 and 200; compare its lifecycle with utubettl. Reproduce the RW stop and dropped-tube cases from the issue, then verify that stop returns, fibers terminate, and dropping a tube leaves no TTL fiber using the supplied checks.
由索引模型根据 Issue 内容生成。
描述
Environment: queue master (07fd732), Tarantool 3.8.0 (also the same code in 1.5.0). memtx.
Summary
fifottl (and therefore limfifottl) creates its stop channel as an unbuffered fiber.channel() (fifottl.lua#L200), but the TTL fiber only reads it in the box.info.ro == true branch (fifottl.lua#L171-L177). So:
tube.raw:stop()called while the instance is RW blocks the caller forever.fifottlhas nomethod.drop, sotube:drop()never callsstop()at all: the space is dropped and the TTL fiber leaks, one per dropped tube. After the instance becomes RO the leaked fibers sit in thesync_chan:get(0.1)poll loop forever.utubettlusesfiber.channel(1)so itsstop()returns, but the fiber keeps running in RW;utubettl'sdrop()then makes it crash on the dropped space (attempt to index field 'watch' (a nil value)).
Repro
local fiber = require('fiber')
box.cfg{}
local queue = require('queue')
-- 1. stop() blocks while RW
local tube = queue.create_tube('t', 'fifottl')
local done = false
fiber.create(function() tube.raw:stop(); done = true end)
fiber.sleep(1)
print('fifottl raw:stop() returned within 1s:', done) -- false (utubettl: true)
-- 2. drop() leaks the fiber
local function ttl_fibers()
local n = 0
for _, f in pairs(fiber.info()) do if f.name == 'fifottl' then n = n + 1 end end
return n
end
local before = ttl_fibers()
for i = 1, 3 do queue.create_tube('leak_' .. i, 'fifottl'):drop() end
fiber.sleep(0.5)
print('fifottl fibers leaked by 3 drops:', ttl_fibers() - before) -- 3
Output on master:
fifottl raw:stop() returned within 1s: false
fifottl fibers leaked by 3 drops: 3
Expected
stop() returns in both RW and RO mode and the fiber actually terminates; drop() stops the fiber before dropping the space (as utubettl tries to do), and does not leave the fiber running against a dropped space.
Suggested fix
Check a stop flag (or the channel with a zero timeout) in the RW branch of the loop as well, make stop() wait for the fiber to finish before clearing self.fiber, and add method.drop to fifottl that calls stop() first. fifottl should also use a buffered channel like utubettl so stop() cannot block the state machine fiber.
- 主要语言
- Lua
- 星标
- 244
- 派生
- 56
- 平均合并
- 6 天 8 小时
- 30 天内合并 PR
- 1
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
tarantool/queue 的其他 Issue
-
documentation good first issue
难度 1/5 1 小时以内 新手友好度 85/100
-
难度 3/5 1-2 天 新手友好度 76/100
-
难度 4/5 3-5 天 新手友好度 48/100
-
1sp bug teamE
难度 4/5 3-5 天 新手友好度 25/100
-
bug
难度 4/5 3-5 天 新手友好度 35/100
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
-
bug
难度 2/5 1-3 小时 新手友好度 68/100
LandSandBoat/server#11579 ·
-
难度 2/5 1-3 小时 新手友好度 76/100
ArchiveTeam/sinavideo-grab#7 · 3 个 reaction ·
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
mailcow/mailcow-dockerized#7480 ·
-
mapper bug
难度 2/5 1-3 小时 新手友好度 88/100