SPLICE_F_NONBLOCK can block on a pipe shared with another process
维护者通常 3 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- c, macos
调研方向
Start in src/syscall/io.c and read the io_xfer, io_xfer_once, sys_splice, and splice_drain_chunk paths described in the issue. Compare the input and output pipe races, then investigate macOS pipe APIs for a per-operation nonblocking transfer that preserves data already read. Done means SPLICE_F_NONBLOCK returns without parking the vCPU in both races, without changing nonblocking behavior for other processes sharing the pipe.
由索引模型根据 Issue 内容生成。
描述
splice with SPLICE_F_NONBLOCK can still block when another process works on the same pipe between a readiness check and the host transfer. There are two windows, both in src/syscall/io.c:
- Input: on a pipe that elfuse does not own (for example inherited stdin),
io_xferanswers a per-call nonblocking read withpoll(0)and then a plainread. When a sibling process drains the pipe between the two calls and the writer stays open, thereadparks the vCPU thread, so the splice hangs instead of returning EAGAIN, and guest signal and teardown checks cannot run. A socket input is not affected, becauseio_xfer_oncealready passesMSG_DONTWAIT. - Output: before each read,
sys_splicechecks the output pipe's free room withpollandfstat, but that reserves nothing. When another writer fills the pipe between the check and the write, the chunk has already been read, andsplice_drain_chunkblocks inio_xferon the output despite the flag.
Linux holds the pipe lock across the check and the transfer. macOS has no per-call nonblocking read or write for a pipe, and setting O_NONBLOCK on the description would change it for every process that shares it. Making the output write nonblocking would close the second window, but it would lose the chunk already taken from a pipe or socket input.
Found in review on #463, where both windows are now stated in the code comments.
- 主要语言
- C
- 星标
- 278
- 派生
- 31
- 平均合并
- 2 天 22 小时
- 30 天内合并 PR
- 18
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
sysprog21/elfuse 的其他 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 86/100
维护者通常 3 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 3 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 3 天内回复
-
难度 4/5 3-5 天 新手友好度 48/100
维护者通常 3 天内回复
-
难度 5/5 一周以上 新手友好度 25/100
维护者通常 3 天内回复
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 1 天内回复
-
update-request
难度 2/5 1-3 小时 新手友好度 62/100
msys2/MINGW-packages#33004 ·
维护者通常 1 天内回复
-
area:buffer good first issue type:documentation
难度 2/5 1-3 小时 新手友好度 86/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
sudo-project/sudo#586 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
OpenPrinting/cups#1795 ·
维护者通常 1 天内回复