Tell macOS binary users when a newer release is available
维护者通常 1 天内回复
评估
这个 Issue 还没有评估数据。
描述
Problem
A candidate who runs the prebuilt macOS binary from the latest release has no way to learn that a newer build exists. Every successful build of main replaces latest (docs/install.md), several times a day at the current pace, but the running binary never says so. The only way to find out is to open the releases page by hand and compare the commit ./codetrial --version prints with the one the release names, since the package version stays 0.1.0 across builds. In practice that check is skipped, so candidates keep practicing on builds that already have fixes they are missing, and a bug report from such a build describes behavior main no longer has.
docs/desktop.md already lists automatic updates as something the desktop app does not do. This asks for something smaller than updating: telling the candidate that an update exists.
Proposed behavior
The lobby checks whether the latest release names a different commit than the running binary, at three moments:
- When the binary starts and the lobby first loads.
- When the candidate ends an interview and returns to the lobby.
- Every hour on the hour while the lobby stays open and no interview is running.
When a newer build exists, the lobby shows a dialog that names the running commit and the release's commit and links to the release page (or the macOS asset). No check runs and no dialog appears during an interview.
Scope
The CLI binary for macOS (codetrial-aarch64-apple-darwin.zip from latest) only, because macOS is the only platform I can test on. The check itself does not depend on the platform, so Linux, Windows and the desktop app's desktop-latest can follow once someone who can test them picks them up. Downloading or replacing the binary is out of scope: the candidate still replaces the executable by hand, keeping config/, as docs/install.md describes.
Acceptance criteria
- A macOS release binary older than
latestshows the dialog at each of the three moments above, with a working link. - A binary that matches
latestshows nothing. - A failed check (no network, a GitHub error, the short window in which
latestresolves to nothing while it is republished) shows nothing and does not affect the lobby or an interview. - Nothing is checked or shown while an interview is running.
Implementation notes
The running commit is already known: build.rs embeds the first seven characters of GITHUB_SHA as CODETRIAL_BUILD_COMMIT, and the release job creates latest with --target "$GITHUB_SHA", so the two can be compared directly. Moments 1 and 2 are one code path: leaving an interview navigates to /, so the lobby loads afresh either way.
Two ways to make the check, compared:
- The server asks GitHub (
GET /repos/sysprog21/codetrial/releases/tags/latest) and caches the answer, and the lobby asks the server through a new endpoint. The page'sconnect-srcstays as it is, and one GitHub request per hour serves every open tab, well inside the unauthenticated limit of 60 requests an hour. - The lobby asks GitHub directly. This needs
https://api.github.comadded toconnect-srcin src/web/policy.rs, and every open tab makes its own requests.
The first keeps the page's policy unchanged, so I would start there.
Questions
- Should the check be on by default, or opt-in, given that it sends a request to GitHub that the binary does not make today?
- A build from source has a commit too, but usually not one
latestwill ever name. Should the check run only in release builds, for example only whenGITHUB_SHAwas set at build time? - After the candidate dismisses the dialog, should it stay hidden until the next release, or appear again at the next check?
Related
#153 (merged) made a binary report the commit it was built from, which is what this compares. #14 (merged) introduced the single rolling latest release this reads. #494 (merged) publishes desktop-latest for the desktop app. I found no existing issue or PR about update notifications.
- 主要语言
- Rust
- 星标
- 215
- 派生
- 141
- 平均合并
- 1 天 12 小时
- 30 天内合并 PR
- 232
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
sysprog21/codetrial 的其他 Issue
-
Audio output can be confirmed without playing a test sound可能已有人在做 @ChenYingHan1121 于 11 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 62/100
sysprog21/codetrial#359 · 9 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
Reset or Show pressed while the task cube is turning does not stick可能已有人在做 @YEH-YU-YANG 今天认领。 未关闭
sysprog21/codetrial#558 · 已指派 1 人 ·
维护者通常 1 天内回复
-
Treat low-evidence candidate speech as unassessed可能已有人在做 @Danielncku 今天认领。 未关闭
难度 5/5 一周以上 新手友好度 35/100
sysprog21/codetrial#553 · 1 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
Web lobby cannot reopen Setup after configuration可能已有人在做 @YEH-YU-YANG 于 3 天前认领。 未关闭
sysprog21/codetrial#525 · 3 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
-
Offer a way back to Setup from the lobby可能已有人在做 @Patriciaath999 于 4 天前认领。 未关闭
sysprog21/codetrial#513 · 4 条评论 · 已指派 1 人 ·
维护者通常 1 天内回复
查看 sysprog21/codetrial 的全部 Issue
相似的 Issue
-
bug priority: low ui
难度 2/5 1-3 小时 新手友好度 65/100
storytold/photocraft#10370 · 1 条评论 ·
维护者通常 1 天内回复
-
area:doc bug in progress needs-triage
难度 2/5 1-3 小时 新手友好度 72/100
bherbruck/solvecraft#9634 · 2 条评论 · 1 个 reaction ·
-
inflate: total_in uses plain += on c_ulong (32-bit on Windows), panics in debug for streams > 4 GiB未关闭
难度 1/5 1 小时以内 新手友好度 85/100
trifectatechfoundation/zlib-rs#570 · 1 条评论 ·
-
bug discord-triage
难度 2/5 1-3 小时 新手友好度 84/100
LanternOps/breeze#10755 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
aranya-project/aranya#803 ·