Subscriptions don't call `onUnsubscribe` if a socket is unexpectedly closed
还没有人认领这个 Issue。
评估
调研方向
Start by reading the subscription cancellation and socket error handling paths to find where onUnsubscribe is called and how unexpected closure is handled. The issue gives no file or test names, so trace those paths from the subscription entry point; done means onUnsubscribe is called when the socket closes unexpectedly as well as on formal cancellation.
由索引模型根据 Issue 内容生成。
描述
onUnsubscribe is currently only called when a subscription is formally cancelled by the user. If a socket error closes the connection, the subscription isn't alive anymore, but because onUnsubscribe isn't triggered there's no good way of knowing that this event was omitted.
I've currently worked around it using ARC retain/release calls. On deinit of a reference type, the onUnsubscribe is implied, though I'm not even certain that this works in practice.
- 主要语言
- Swift
- 星标
- 182
- 派生
- 29
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
swift-server/RediStack 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 55/100
swift-server/RediStack#135 ·
-
难度 3/5 1-2 天 新手友好度 45/100
swift-server/RediStack#133 · 5 条评论 ·
-
难度 5/5 一周以上 新手友好度 25/100
swift-server/RediStack#131 ·
-
难度 5/5 一周以上 新手友好度 25/100
swift-server/RediStack#129 · 1 条评论 ·
-
难度 3/5 1-2 天 新手友好度 35/100
swift-server/RediStack#127 ·
查看 swift-server/RediStack 的全部 Issue
相似的 Issue
-
bug good first issue help wanted
难度 2/5 1-3 小时 新手友好度 63/100
marcovisona/arca#5 ·
-
enhancement good first issue
难度 2/5 1-3 小时 新手友好度 78/100
luis-guillen/airy#2 ·
-
accessibility bug medium-priority mobile
难度 2/5 1-3 小时 新手友好度 83/100
lognorman20/monaco#6247 ·
-
documentation windows
难度 1/5 1 小时以内 新手友好度 85/100
-
难度 1/5 1 小时以内 新手友好度 85/100
521xueweihan/HelloGitHub#4060 ·